awesome! great talk

we enjoyed

Cool thanks @micha !

dangit i missed it

on the plus side, i have real internet now. tethered for 2 wks, what misery

@alandipert: that could be interesting, do all the downloads!!

http://hmpg.net/downloadwww.gif

Hahahaha

@jumblerg do i understand well that there is still no support for initial form data? i saw some code which was reading default values from the :val keys of input elements, but then in practice i see the following:

(let [form-data (cell nil)]
      (row :ah :mid
        (form
          :change (partial reset! form-data)
          :submit (partial js/console.debug "form data: ")
          (line :key :amount
                :val "123"
                :f 14 :b 1 :bc grey :sh (em 30)))
        (row :ah :mid
          (cell= (pr-str form-data)))))

so i have 1 line input with a default value of 123 and below it would like to see a specially rendered version of the form data which is kept in sync as i type into the form

on page load i see

__123__
{}

press enter: 123__ {:amount "123"} console: form data: {} `

i would expect both the console.logged form data and the specially rendered version on page load to be {:amount "123"} instead of {}

what am i missing?

okay, here is an easier to try and observe version:

(let [changed-data (cell nil)
          submitted-data (cell nil)]
      (form
        :g 12
        :change (partial reset! changed-data)
        :submit (partial reset! submitted-data)
        (line :key :amount
              :val "123"
              :f 14 :b 1 :bc grey)
        (elem "changed data:" (cell= (pr-str changed-data)))
        (elem "submitted data:" (cell= (pr-str submitted-data)))))

123
changed data: {}   
submitted data: nil  

123
changed data: {:amount "123"}
submitted data: {}  

1234
changed data: {:amount "1234"}
submitted data: {}  

1234
changed data: {:amount "1234"}
submitted data: {:amount "1234"}  

I would have expected • {:amount "123"} OR nil as changed data in step 1 • {:amount "123"} as submitted data in step 2

@onetom: I think this is an issue with how the default value is handled, should it be contained in a cell?

u mean :val (cell "123")?

Well referencing one yes

Like shouldn't that be the submitted-data

looking at https://github.com/hoplon/ui/blob/master/src/hoplon/ui.cljs#L375

(when change (cell= (change (clean *data*)))) ;; init *data* to value of form fields on render

I'm not sure I don't use UI

just wanted to say that 🙂

in ui, the dom element value is maintained based on a keyword unless u override it with the :val attribute

Like usually I use the change event on the field

To update the cell

this could work for the usual data editing flow:

(let [changed-data (cell nil)
          submitted-data (cell nil)
          initial-data (cell {:amount "123"
                              :extra "data"})]
      (form
        :g 12
        :change (partial reset! changed-data)
        :submit (partial reset! submitted-data)
        (line :key :amount
              :val (cell= (:amount initial-data))
              :autofocus true
              :f 14 :b 1 :bc grey)
        (elem "changed data:" (cell= (pr-str (merge initial-data changed-data))))
        (elem "submitted data:" (cell= (pr-str submitted-data)))))

and the initial-data should be combined with the changed and submitted data to get a full dataset back after editing

which is actually not too bad...

it's just slightly verbose

Yeah it's not to difficult if you can't get the UI binding to work

@jumblerg https://github.com/hoplon/ui/blob/master/src/hoplon/ui.cljs#L471

(.addEventListener (mid e) "click" (bound-fn [_] (or submit' *submit*) *data*))

(.addEventListener (mid e) "click" (bound-fn [_] ((or submit' *submit*) *data*)))

@onetom: yes. the forms are still a work in progress, but that's definitely a mistake: if you could patch the click handler so the submit function is evaluated and applied to the form data it would be much appreciated.

@jumblerg do you have any playground for them? i saw you removed the tst/hoplon/ui-test.cljs. i guess you want to move it into the tst/hoplon/demo.cljs, right?

im just merging the latest hoplon/ui into our branch as we speak, then will migrate our app to it. the above form example clears up our issues with the initial data hopefully.

it's a bit manual but it seems to work.

i go back and forth between the two, depending upon what i'm doing. at some point the demo needs to be separated out into a separate project.

btw, i've tried to add another page under tst/hoplon but when i loaded that page via i got redirected to any idea why could that happen?

i recall encountering a bug in the hoplon boot task with the symtoms you're describing; it has been a problem for a while.

@jumblerg how am i supposed to clear a form? pretty common example: the login form on an SPA should be cleared after login, so when i logout, i should be redirected to the login screen, where the password field should be empty. otherwise i can just press enter and im logged in again.

is there a way to profile which cells are going slow?

@thedavidmeister chrome profiler will show slow code, which can be in cells

@alandipert you mean like this?

@onetom to clear a form can't you just do (swap! hoplon.ui/*data* empty)

I believe this used to not work, but it does in the current version with the hoplon binding stuff

(that's inside the submit function I mean)

@thedavidmeister yeah, doesn't that help?