Fork me on GitHub
#hoplon
<
2016-06-20
>
leontalbot17:06:20

@jumblerg: If I clone hoplon/hoplon master right now, would I get the most compatible version of hoplon for IE 8?

jumblerg17:06:57

although, i need to look into why the tests are failing more deeply, i'm going to take care of that this afternoon.

jumblerg17:06:43

the tests may have actually caught something i missed with my minimalist app in firefox

leontalbot17:06:25

allright good! Thanks!

jumblerg17:06:24

it would be terrific if you gave it a try and let me know of any issues you find.

leontalbot17:06:34

of course, just ping me when ready!

micha17:06:51

@jumblerg: can we back out the protocol stuff?

micha17:06:57

the ->node thing

jumblerg17:06:07

@micha: sure, i was thinking about stripping ->node, both as a fn and a protocol, from the source altogether based our last convo, given that the string and number cases are no longer necessary

micha17:06:44

how are the string and number cases no longer necessary?

jumblerg17:06:57

also need to figure out how to do the ui tie-in

micha17:06:35

(div "hello") i think should continue to be supported

micha17:06:04

i don't see any problem with how it was, can't we just leave it like that for a while, until we have a reason to change it?

micha17:06:08

so we don't break stuff

jumblerg18:06:33

on the go, will address when i get behind my laptop in a bit

jumblerg18:06:18

right now ui depends on it, but i'm open to diff implementation as discussed

jumblerg18:06:02

wrt string, number, i thought you were suggesting we didn't need them a few days ago, but i don't recall the particulars, probably misunderstood.

jumblerg18:06:03

something to do with prev HLisp implementation

micha18:06:36

i meant that the ->node function was introduced to support strings originally

micha18:06:56

there may be a better way to do it that eliminates that, but it doesn't seem worthwhile at this point

micha18:06:23

at some point it got feature creep to add numbers

micha18:06:08

changing that now doesn't seem very attractive, because it could break a lot of things

micha18:06:29

and there isn't really any pressing need to do so

leontalbot19:06:43

@jumblerg on IE 8 (not 9) I still got a problem

jumblerg19:06:26

do you have the dev tools removed? it works for me.

jumblerg19:06:44

or run with simple, advanced opts

leontalbot19:06:05

I am on simple

leontalbot19:06:26

should I check out how to remove devtools on browserstack?

leontalbot19:06:26

do you see hoplonKids="[object Object]" yourself?

leontalbot19:06:26

I don't get this with IE9+

leontalbot19:06:58

this cause some parts of my pages not to load

leontalbot19:06:28

the one that depends on castra cells I believe

jumblerg19:06:59

checkout head~ and build against that

jumblerg19:06:09

i'm going to revert the node thing anyway

leontalbot19:06:38

git clone --branch head~

jumblerg19:06:42

git checkout HEAD~

jumblerg19:06:34

that will take your working directory back a commit

jumblerg19:06:08

i’m back at my desk, looking into this stuff now

leontalbot19:06:21

is this correct: HEAD is now at 17bd97b... ie-8-proof ->node extensibility, purge hoplon kids atom in body on page reload

jumblerg19:06:33

you should see something like

$ git checkout HEAD~
Previous HEAD position was 17bd97b... ie-8-proof ->node extensibility, purge hoplon kids atom in body on page reload
HEAD is now at 98adfce... add ie 8 special sauce to -head property

leontalbot19:06:16

sorry I am not good at git

leontalbot19:06:24

should I checkout again?

leontalbot19:06:12

oh ok, I did git checkout origin/head

leontalbot19:06:34

doing git checkout HEAD~ I see exactly what you printed

jumblerg19:06:35

no worries, i’m not great at in either. sledgehammer your local hoplon repo via

git reset --hard origin/master

jumblerg19:06:28

i’m looking into this stuff now, give me a few mins

leontalbot19:06:04

IE 9+ works with this branch

leontalbot19:06:23

IE 8+ doesn't work. I don't see anything in my page

leontalbot19:06:30

I know you are fixing stuff

leontalbot19:06:38

just wanted to let you know

jumblerg21:06:06

@micha: i switched over to thedavidmeister’s more elaborate test app and started using this for x-browser testing; we’ve been broken on ie 8 for a long time.

micha21:06:53

bummer, what was broken?

jumblerg21:06:28

most of the commits, including the most recent ones, work on minimal hoplon apps, as well as the apps i’m creating internally, but this thing seems to be catching a number of deficiencies. i’m not sure what the deltas are yet between those apps that pass and the test app, but i’m working to find out.

jumblerg21:06:46

it is a time-consuming process

micha21:06:01

could be something about how the test harness works maybe

micha21:06:11

like if the tests raise some bug themselves

jumblerg21:06:18

that’s what i was initially suspicious of. but i created a separate test app using his index.cljs.hl page, and i’m using that for functional tests.

jumblerg21:06:13

many of the element contstructors in hoplon are html 5

jumblerg21:06:46

one way to deal with this could be to associate some metadata on each one indicating which browser versions they work with, then warn when they are used

jumblerg22:06:17

@leontalbot: if you use any html 5 elements in your app, it will break because they’re not supported by ie8 in the first place

leontalbot22:06:28

Is css 3 still ok ? (can't test right now)

jumblerg22:06:33

i think this could be the issue anyway… this is my hypothesis

leontalbot22:06:16

Ok will test tonight

jumblerg22:06:33

don’t make any changes until i do more research

micha22:06:35

@jumblerg: ie8 should still support those elements, they just have a default implementation

micha22:06:59

you might not be able to css them very well

micha22:06:17

unless you do some other stuff before you use them

micha22:06:53

but you should be able to do body.appendChild(document.createElement("section")) in ie8

micha22:06:58

for example

jumblerg22:06:03

apparently, you can create an element named anything

jumblerg22:06:11

so that’s not it

micha22:06:12

yeah still can

jumblerg22:06:36

which… come to think of it, could be quite useful in ui

jumblerg22:06:12

or in hoplon in general… when new elements are defined, we could make them appear that way in the dom, could be useful for debugging

jumblerg22:06:33

have you considered or attempted this yet?

micha22:06:51

yeah, i didn't find it so helpful really

jumblerg22:06:15

i think it could be handy when not using ids and selectors

jumblerg22:06:42

make it easier to spot things, doesn’t have any production value though, only useful for debugging maybe

micha22:06:02

it's complicated to track the names of things

micha22:06:12

doesn't work very well with higher order constructor things

micha22:06:55

you can also make dev tools extensions in chrome

micha22:06:01

which is kind of a nea idea

micha22:06:49

kind of a mission to maintain maybe

jumblerg22:06:39

could make some pretty cool things possible though

jumblerg22:06:16

@micha: so one of the culprits is the object ctor

micha23:06:03

the object ctor?

micha23:06:09

new Object()?

micha23:06:20

ah, the html-object situation perhaps

micha23:06:29

makes sense to rename that guy

jumblerg23:06:23

that’s what i thought, but that didn’t fix it either

jumblerg23:06:53

i think that is the IFn implementation breaking down on the object Element for some reason