point_up::skin-tone-2 For anyone using symbol-based DSL fragments and honey.sql.helpers, this is an important bug fix (the rest of y'all can ignore it).
(I bumped into it today at work)
@seancorfield Weird that I see the "Edit" and "Close" buttons even though of course I can't do those things, at least via GitHub's UI. Tried pressing "Edit" - it gave me an editor within Slack. Haven't tried actually editing though.
Yeah, I wondered about that. You could try making a little edit and see what happens...
Ah, alright: "Failed to update the issue."
Good to know. Thanks for checking.
Thanks for the fix! Ran into this issue the other day. I originally avoided the helper DSL (because data all the things). Only recently started using the helper DSL. Have to say it’s really growing on me. I find you always end up writing custom merge logic/behaviour with the raw data DSL particularly when you start having logic that affect multiple parts of the query (eg: adds to select and where clause and a group-by). The helper DSL solves this really nicely, now I’m wondering why I wasn’t using it from the beginning. Better late than never, I guess. Thanks again for this awesome library.
We have a lot of conditional query building at work where we'll add select, join, and where in each cond-> clause. Very useful!