I feel like I’m missing something obvious; how would I format an = clause inside of a function call? The approach I expected to work doesn’t do the right thing:

=> (sql/format (sql/call :nullif [:= :id "dsr-000"] false))
["nullif((=, id, ?), FALSE)" "dsr-000"]

@greg316 HoneySQL v1 or v2?

good question, looks like [honeysql "1.0.461"]

On v2:

dev=> (sql/format-expr (sql/call :nullif [:= :id "dsr-000"] false))
["NULLIF(id = ?, FALSE)" "dsr-000"]

(I'm not sure if you can format expressions in v1 -- you can't in v2, you must use format-expr -- but if you format a statement that includes your expression you should do better)

has the same effect in a full expression:

=> (sql/format (sql/build :update :foos :set {:is_default (sql/call :nullif [:= :id "dsr-000"] false)}))
["UPDATE foos SET is_default = nullif((=, id, ?), FALSE)" "dsr-000"]

v1 had some strange behavior in some places with embedded expressions...

hoping I don’t have to fall back to making it a raw string 😅

v2: (there's no build function because it really didn't do much)

dev=> (sql/format {:update :foos :set {:is_default (sql/call :nullif [:= :id "dsr-000"] false)}})
["UPDATE foos SET is_default = NULLIF(id = ?, FALSE)" "dsr-000"]

unfortunately I don’t think upgrading the whole app to v2 is tractable right now, but I’ll put it on our backlog - does look like a nicer API

You can run v1 and v2 side-by-side and migrate on a query-by-query basis.

Different library names and different namespaces.

We're running both at work and slowly migrating from v1 to v2.