Fork me on GitHub
#honeysql
<
2021-04-13
>
orestis09:04:53

Glad to see that honeysql v2 supports DDL statements.

seancorfield16:04:19

Thanks! @orestis It supports a pretty wide range of things now. I started with what the honeysql-postgres library supported, then added a bunch of additional syntax I found in the PostgreSQL docs (and SQL Server and MySQL docs too) while trying to figure out the correct syntax for the nilenso stuff (instead of trying to read their implementation), then added quite a bit of stuff suggested by folks here, including (and especially) @dharrigan

dharrigan16:04:12

You're most welcome! And thank you for your library! I migrated another service to v2 beta1 today, and only had one gotcha

dharrigan16:04:23

which thankfully a test caught, otherwise it would have had dire consequences

dharrigan16:04:04

Perhaps it was a bug in v1 or something in v2, but it caused a AND condition to become an OR condition

dharrigan16:04:08

which would have blasted out my database.

seancorfield16:04:39

Oh? Please open an issue on GH if you can.

dharrigan16:04:53

Would you like to know here first, perhaps it was just my mistake?

dharrigan16:04:58

I can DM you it

dharrigan16:04:00

if you perfer 🙂

seancorfield16:04:58

Whatever works for you…

seancorfield20:04:45

com.github.seancorfield/honeysql {:mvn/version "2.0.0-beta2"} — includes an important bug fix uncovered by @dharrigan — thank you!