holy-lambda

Benjamin 2021-10-06T16:08:35.025400Z

What does the request look like when I have an apigateway for my Lambda where something get's posted to? Is there a :body key? And is that already clojure data? (input is json)

Benjamin 2021-10-06T17:03:07.025700Z

now I figured out the event has a :body key with a string

Karol W贸jcik 2021-10-06T17:08:26.025900Z

Right. Maybe HL should automatically parse the body?

Benjamin 2021-10-06T17:45:25.026100Z

I have no opinion on that either way 馃槄

Karol W贸jcik 2021-10-06T17:46:09.026300Z

@chris.lowe.uk @steveb8n what do you think?

steveb8n 2021-10-06T21:27:31.026600Z

a generic body parser could get complex since there are a lot of different content-types. I don鈥檛 think it鈥檚 a big win in the HL feature set compared to other ideas on the roadmap

Karol W贸jcik 2021-10-07T06:55:44.026800Z

This is probably important for the consistency. HL already auto deserializes the edn & json. Parsing these content-type in body is probably sufficient for 99% cases.

Karol W贸jcik 2021-10-07T06:56:58.027Z

But I will not include it in next release for sure. To much stuff is already in the Changelog.

Karol W贸jcik 2021-10-07T07:02:59.027300Z

And I have to make sure this change will be compatible with the ring specification.

Chris Lowe 2021-10-07T08:36:29.028500Z

> a generic body parser could get complex since there are a lot of different content-types. I don鈥檛 think it鈥檚 a big win in the HL feature set compared to other ideas on the roadmap +1 I鈥檓 happy with the current behaviour. Maybe add something to the docs on what to expect for some common AWS services.