helix

dominicm 2023-09-28T19:53:33.733249Z

fyi, I've just been trying clojurescript master and I'm getting this warning from helix:

Extending an existing JavaScript type - use a different symbol name instead of js/Symbol e.g symbol

   7              ["react" :as react])
   8    (:require-macros [helix.core]))
   9  
  10  
  11  (when (exists? js/Symbol)
  12    (extend-protocol IPrintWithWriter
        ^---
  13      js/Symbol
  14      (-pr-writer [sym writer _]
  15        (-write writer (str "\"" (.toString sym) "\"")))))
  16  
  17  
https://github.com/clojure/clojurescript/commit/6d9ba920ccd5c364df847a9633c1c6c614917981 https://clojure.atlassian.net/browse/CLJS-528 https://github.com/clojure/clojurescript/commit/df04ee2c41ce7683b52c5793d0154ca88771f0f7

lilactown 2023-09-28T23:38:00.128339Z

is the fix to use symbol , then? annoying that it would be broken in older versions of cljs

dominicm 2023-09-29T05:48:55.534419Z

I tested master and symbol seems to work ok there, although now I think about it that might be because it's extending cljs symbol instead

dominicm 2023-09-29T05:50:29.043179Z

Is the change still needed, though? I have a feeling newer versions handle it