Using helix 0.1.3 and shadow-cljs 2.15.13 (which bumps ClojureScript and the google closure compiler), my helix app is throwing an error at every defnc:

TypeError: Cannot read properties of undefined (reading 'set')

that makes sense, given the changelog I read by dnolen

https://github.com/lilactown/helix/issues/90

thanks

the issue is this line of code: https://github.com/lilactown/helix/blob/d903498e65de187632079601043a3ea51a73e509/src/helix/core.clj#L258

and this: > Some ClojureScript libraries assume that because cljs.core loaded goog.object, it would be safe to refer to such definitions directly, i.e. goog.object/get without the necessary require. This pattern can be useful in the writing of macros so that users can elide a require. However, this is now an anti-pattern and will fail. from https://clojurescript.org/news/2021-11-04-release

yup exactly

this looks like a workaround for now https://clojurians.slack.com/archives/C03S1L9DN/p1636114984367400

the compiler flag, i mean

mmhmm

It’s an easier fix for tick since it’s in a cljc file and the require can be within a reader conditional

yeah. it's frustrating, since there isn't really a "best" way to emit code from a macro that does JS interop now

yea

i'll probably create a helper fn in the cljs ns to handle setting the display name