graphql 2019-07-29 | Slack Archive

Lennart Buit13:07:55

I was looking at lacinias error attaching. I noticed that the spec suggests that if an error occurs within a collection, that the :path key of the error contains an index of the offending object in that collection. For example here: https://graphql.github.io/graphql-spec/June2018/#example-90475. That appears to be not the case in Lacinia. Am I missing something here? / Is this something you consider a bug? / If you do, is this something you consider accepting PRs on?

Lennart Buit13:07:24

humm, I am finding some code that is adding this index, but so far no real luck at really finding this index in the result

Lennart Buit14:07:44

I think I found a bug here, where a function attempts to include this index in the result, but fails to do so because this index is appended in the wrong key. This however means that some tests were written with the wrong assumption.

Lennart Buit14:07:03

I have proposed a patch here: https://github.com/walmartlabs/lacinia/pull/294 🙂.

hlship16:07:02

Thanks! I'll be looking into this.

👍 4

2019-07-29

Channels