Fork me on GitHub
#graphql
<
2017-06-21
>
boubalou01:06:32

I would say the same thing there, @shaun-mahood ! Good work @hlship and the team behind you if there is any. 🙂

hlship15:06:45

boubalou: Check the commit log. I've been doing a lot of work on it, but far from the only one. And we accept quality PRs.

jonpither15:06:44

hi - is there a way in Lacinia to coerce args before they reach a resolver? I.e. I want to namespace the args so I can use them directly in Datomic...

jonpither15:06:33

preferably to coerce based on some metadata inside of the query type

hlship15:06:45

boubalou: Check the commit log. I've been doing a lot of work on it, but far from the only one. And we accept quality PRs.

jonpither16:06:24

^ nm, I have all the info indeed inside of the resolver to coerce the args 🙂

hlship18:06:57

So we've been chatting internally, and want to pull resolver decorators out. File under "seemed like a good idea at the time." The reality is that the code that builds the resolver map passed to attach-resolvers can do this work at least as well. Any thoughts or objections?

hlship18:06:39

It's only been in Lacinia since 0.17.0 (22 May 2017).

stijn18:06:33

@hlship no objections. we're using it, but it's only a few lines of code to apply them to the resolver map instead. I think what mattered most from the issue that I created was the move from metadata for type tagging to a wrapper record

hlship18:06:53

Great, and you have that back in 0.18.0.

stijn18:06:10

I like it that you're trying to keep lacinia as simple as possible

stijn18:06:52

And the schema as a map is a perfect abstraction for doing all kinds of preprocessing