Fork me on GitHub
#graalvm
<
2020-02-28
>
katox08:02:52

Hi, nice channel 😉. I noticed that you pick up some tips - to avoid tearing your hair out - here is one that took me a while: To let Graal config the reflector for e.g. Statement[]you need to provide a rule for "[Ljava.sql.Statement". An example is in https://github.com/leafclick/pgmig/blob/master/graal.json

🎉 4
borkdude08:02:18

@katox interesting project! feel free to add it to the list at https://github.com/lread/clj-graal-docs. Also feel free to add any other hints and tips.

katox11:02:51

Cheers, see you at :clojureD

zilti16:02:29

Oh, I'll be at :clojureD as well 🙂

👍 4
Alex Miller (Clojure team)17:02:15

could someone provide a straightforward set of instructions to reproduce the CLJ-1472 problem on latest Clojure?

lread19:02:11

Hiya @alexmiller, we have described the issue on https://github.com/lread/clj-graal-docs/tree/master/CLJ-1472 but steps for reproduction are perhaps a bit buried in all the verbiage. I’ll go and distill and ping back when done.

Alex Miller (Clojure team)19:02:06

what we really want is not a fancy script but just a real basic list of how to repro - here's a source file, run x, run y, fails

Alex Miller (Clojure team)19:02:24

I'm sure I could do that, but I'm doing 9 other things so it would help :)

lread19:02:49

sure, am happy to do it

lread19:02:00

I’ve been away from my happy Clojure place for far too long. Will be nice to dip my toe back.

🙂 4
Alex Miller (Clojure team)21:02:16

you can just attach it to CLJ-1472 if you get to it

lread22:02:49

uh… was working on it

lread22:02:00

you are too fast @borkdude!

borkdude22:02:21

I'm off for tonight, will attach to CLJ-1472 after ClojureD. Ohh sorry @lee! Maybe you can not look at my repro and see if you come to the same thing 🙂

borkdude22:02:48

@lee Go ahead and you attach it to CLJ-1472

lread22:02:30

ya mine was pretty much equivalent.

lread22:02:13

but more detailed

lread22:02:17

but yours is good.

borkdude22:02:54

if you did it without lein it may be preferable

borkdude22:02:07

gotta get some sleep now, giving a talk tomorrow 🙂

lread22:02:51

have fun! looking forward to videos!

✔️ 4
lread22:02:08

mine was just a new page on clj-graal-docs. Less convenient to run than yours but deps based.

borkdude22:02:44

adding page to clj-graal-docs + clj-1472 seems good, I'll let you finish it

lread22:02:24

I’ll push and we can compare later. Can always delete.

Alex Miller (Clojure team)22:02:31

deps definitely preferrred

Alex Miller (Clojure team)22:02:01

so would like to see yours @lee

lread22:02:38

Here’s what I’ve pushed: https://github.com/lread/clj-graal-docs/blob/master/CLJ-1472/steps-to-reproduce.md @alexmiller, I understood you to be looking for raw description rather than scripts, let me know if this is what you had in mind. I’ll wait to review with @borkdude before attaching to CLJ-1472

borkdude22:02:35

@lee > Note: A thorough tester will repeat all tests for GraalVM 19.3.1 on JDK11. Let's leave JDK11 out of the equation, it has its own problem with the conditional MethodHandle in clojure.lang.Reflector (documented on the main README.md)

lread22:02:58

hey go to sleep!

borkdude22:02:58

That also has a workaround, but let's only talk about this for now

lread22:02:13

I’ll update, thanks for feedback

borkdude22:02:35

Personally I prefer to just download GraalVM from the downloads page and not install another extra tool like SDKMAN

lread22:02:13

That’s fine too, but I like SDKMAN! because it lets me switch between versions easily.

borkdude22:02:37

Yes, but for a repro it seems unnecessary (same as lein, let's just stick to deps + raw download when possible)

lread22:02:53

Just describing how I tested.

borkdude22:02:56

The rest of the text seems fine to me, excellent job

lread22:02:26

Now go to sleep! simple_smile

lread23:02:55

glad to be of use! pushed borkdude’s (notice I did not use the @ on his name because I want him to sleep) feedback.