Fork me on GitHub
#funcool
<
2016-06-09
>
kardan15:06:12

I tried to set a cookie to a string with an empty space in it. Took a bit to understand why the response was “No response sent for POST request to /login (last handler: catacumba.impl.handlers$eval14933$fn$reify__14935)"

kardan15:06:30

I realise that it should not be possible, but not sure if it would be possible (or wanted) to have a better error message

kardan15:06:39

Anyway, just wanted to share

mccraigmccraig15:06:55

what's happening to the promesa promise.monad namespace @niwinz ? is it moving somewhere else ?

niwinz18:06:45

@kardan: the error message seems completly unrelated to cookies...

niwinz18:06:57

it seems you are not returning complete response fom the handler...

niwinz18:06:24

@mccraigmccraig: it will be moved inside cats directly as it already done with core.async and manifold, just for consistency.

kardan18:06:34

@niwinz: I have to admit that I only did a quick test. But to me it seemed like adding a cookie where the {:cookiename {:value “token abcqwe”}} would render that error message

niwinz18:06:08

that error message is printed by ratpack when no response is returned

niwinz18:06:31

it is completly unrelated to cookes...

niwinz18:06:48

and is quickly reproducible just not returning a response from a handler

kardan18:06:46

Maybe I’m confusing myself. Just took up my side project in Catacumba after a period of a lot of other work

niwinz18:06:37

In any case, if you have some trouble, please let me know I'll try to help you to solve it

kardan18:06:29

I do have some trouble but I’ll try to look at it with a rested mind first

kardan20:06:54

@niwinz setting a cookie that includes an empty space, like “a b” will error. See https://github.com/kardan/catacumba/blob/cookies/test/catacumba/core_tests.clj#L52

kardan20:06:22

Have not had time to look into the reason.