Clojurians Log v2

There are many answers I could give for this. Unfortunately the current RAD plugins all use UISM, so customizing the UISM on a form component might be your best bet. That would embed you in the right kind of env, and of course you can override the fo/machine, and hand-customize what gets rendered…once in a form, you can use all of the plugin bits like field renderers.

Ok, I'll look into that. I'm fine with experimenting with what structures benefit us and which don't. In that regard: should I expect any considerable downsides/issues from the pattern in the OP?

Well, that thinking wasn’t right at all. Now that I’m looking at the code I realize that the UI plugin is very much dependent on a lot of things, and new namespaces approach won’t work if I want to maintain compatibility with existing rendering plugins. A number of the functions in the form and report nses have internal dependencies on the UISM nature of the existing beast. It’s a bit bigger job.

making it rad2 may be the safest, if many things break it would make it easier to migrate

yeah, but that means also making a new ui plugin, since they are kind of tightly coupled

Yes but is it really much more work than making a statecharts/state machine mix? It's definitely less complexity?

I’m actually going through right now and seeing what it would take.

isn’t the statechart already running? If so, the data model is already populated. I don’t think hot-code reload should restart the chart, right?

We could discuss an API change/improvement where the aliases are stored somewhere else perhaps? But aliases should be something that is pretty darn static, so the answer is probably going to be at least restart the chart.

Yeah maybe the real question is what kind of workflow is efficient to develop and debug statecharts

exactly, and your data needs change slowly compared to step by step coding…

Seems like there is unforeseen consequences I'm looking into it

When saving the id changes from tempid to actually id maybe it can cause issues?

Well, everything about a state chart is actually stored in the state map. Isn't it? Trmpid Rewriting is a global operation on that. I have a vague memory of that not actually being true 😕

If you look in the fulcro inspect database, is the temp ID left around as the session ID?

, I wonder if we rewrite any pending events in the state chart event queue.

So yeah, if the ident is used to derive the session ID, and a temp ID is involved, I may have missed some cases

I don't remember how I implemented the event queue.

I will get back to the bug later this week, it's a massive component and a massive statechart with some subcomponents having statecharts that talk back to the parent statechart so there is quite a lot to unpack there to really understand what goes wrong

but it went from "working" to getting stuck with that commit

but you said earlier “it works”. What then went wrong?

The form where I had to use a use-effect hook instead of use-statechart because it wasn't mounted on id change because the key was not set by fulcro

That is working I can use use-statechart now

But it broke that other component ik talking about in a way I don't understand yet

ok

Works thanks!

(hooks/use-lifecycle
   (fn [] (println :mount-form))
   (fn [] (println :unmount-form-id)))

never noticed that before maybe it's a react 19 thing too?

I realized it because I have a statechart in that form and on some event I do:

(scf/resolve-actor env :actor/component)

Is it the same component? The component has to unmount for lifecycle to fire

the defsc-form is in the router fo/route-prefix "question" fo/id question/id and use-statechart call is in its body so yeah it's never unmounted by react when you change the entity to a new one with rad/route-to

I ended up doing

(hooks/use-effect
   (fn []
     (scf/start! app {:machine ::QuestionForm
                      :session-id [::QuestionForm [:question/id question-id]]
                      :data {:fulcro/actors {:actor/component {:component ::QuestionForm
                                                               :ident [:question/id question-id]}}}})
     (fn []
       (scf/send! app [::QuestionForm [:question/id question-id]] :event/unmount)))
   [question-id])

don't really need the return value of use-statechart in the body of the form anyway and couldn't figure out how to pass it down to renderers so I do things like

(fn [{::form/keys [form-instance]}]

                                                                      (let [props (comp/props form-instance)
                                                                            ident (comp/ident form-instance props)
                                                                            config (scf/current-configuration form-instance [::QuestionForm ident])] ...)

Technically the factory should be using the form’s ID as the react key, which should force react to unmount/mount when the ID changes 😕

oh, but you have it as a target in a router, and the router makes the factory then

Ah, so that is technically a bug in the dynamic router. It should make a keyfn for the target that uses that target’s ident.

I’ll push a patch

Try fulcro 76a6bdd08396dfd0b595149892041c968e7d9ccf