Clojurians Log v2

OH

Yeah, I did change input ref

are you using :ref or :inputRef?

inputRef isn’t something react itself supports…but is a common library name for it

:ref

I think my input wrappers used to proxy that, but I couldn’t figure out why, so I removed it

hm…so, yeah, I had to rewrite how the DOM inputs worked because of changes in 19

there is some chance I broke :ref, but I thought I tested it. Are you saying that with rc2 and react 18 it is OK though?

I didn't touch react version

it works with 48d7b63a1e81ca37cc965f9b0d9059b053f4db3c

ok, so yeah, I broke something about ref then

The dom ns in commit acc712caa54629bfa887273919ee72e95f1e3467 is where I had to change it to use hooks instead of older stuff that relied on API of react that they removed.

feel free to hack on it and see if you can spot the issue. You can also turn off wrapped inputs (see the docs) and use the synchronous transactions (with !! versions of mutations) and then you’ll be using the low level native inputs.

ok thanks we'll do

I've add issues with cljc files, clj part doesn't compile because it returns react-version 0

With react 18 I have a dropdown that stops working with the latest changes to fulcro:

dropdown.cljc:209 Uncaught TypeError: Cannot read properties of null (reading 'setSelectionRange')
    at eval (dropdown.cljc:209:26)
eval	@	dropdown.cljc:209

react-dom.development.js:4313 Uncaught TypeError: Cannot read properties of null (reading 'setSelectionRange')
    at eval (dropdown.cljc:209:26)
eval	@	dropdown.cljc:209

ah, should fix the compile issue 😛 The other one I don’t understand….

seems likely unrelated to Fulcro

rc2 released

also fixed CI problem

the dropdown error only happens with the new version of fulcro it's happening in an on-click event:

(fn [evt]
                 (evt/stop-propagation! evt)
                 (when-not open?
                   (-> input-ref
                       (.-current)
                       (.setSelectionRange 0 0)))
                 (toggle-menu))

I'd share the namespace but then it has further deps so I will need to make a minimal repro first when I'm back on fulcro's head

@tony.kay I've been running 3.9.0-rc1 with React 18.3.1 for a couple of days without issues. Today I upgraded to React 19.1.0 and started seeing this warning at runtime:

2025-06-25T00:17:32.380Z INFO [com.fulcrologic.fulcro.algorithms.indexing:100] - component 's ident ([:page/slug nil]) has a `nil` second element. This warning can be safely ignored if that is intended. Props were {}

(defsc Page [this {:ui/keys [editing] :page/keys [slug data]}]
  {:use-hooks? true
   :ident :page/slug
   :route-segment ["v" :slug]
   :query [:ui/editing :page/slug :page/data]
   :initial-state {:ui/editing false :page/slug "default" :page/data {}}
   :will-enter
   (fn [app {:keys [slug]}]
     (dr/route-deferred [:page/slug slug]
       #(df/load! app [:page/slug slug] Page
          {:post-mutation `route-success
           :post-mutation-params {:slug slug}
           :fallback `route-failure})))}
  (if editing
    (puck/editor
      {:config config
       :data data
       :onPublish (fn [data]
                    (comp/transact! this [(save-data {:page/slug slug :page/data data})])
                    (m/toggle! this :ui/editing))})
    (ui-page-content
      {:title slug
       :actions (more-actions
                  {:dropdown
                   (comp/fragment
                     (ui/menu-item
                       {:leftSection (ui/icon {:name :layout})
                        :children "Edit view"
                        :onClick #(m/toggle! this :ui/editing)}))})}
      (puck/render {:config config :data data}))))

hm. THe react version affects nothing in these parts of the internals. I think you have some kind of coincidence

I’ve tested multiple upgrade/downgrade cycles — clearing node_modules and rebuilding from scratch each time — to rule out caching issues or transient build artifacts. The results are consistent: the warning only appears with React 19, never with React 18. It makes me wonder if this is related to stricter timing or lifecycle changes introduced in React 19. I’ll dig a bit deeper and try to put together a minimal reproducible example.

So, the warning you are seeing might be related to a change in rendering speed I guess. The props are empty it seems, which indicates a render before the initialization, which should be impossible

Seems like this fixes it for us https://github.com/fulcrologic/fulcro/pull/570

Thank you. I have not had time to look into it.