Clojurians Log v2
fulcro
Today I was trying to improve the performance a bit for some of my attributes that return large collections.
I got substancial performance gains when I replaced my defattribute by a defresolver and wondered why
Turns out (auth/redact env) in com.fulcrologic.rad.resolvers-common has at least 30% impact on resolvers even though I don't use it
Yeah that was a bad add on my part. That should have been a composable element instead of always in. We could make a new version of the function, and point people to use it instead of the current one
I was just setting up a new workstation and when I went to download the Fulcro Inspector chrome extension there is a warning showing in the Chrome Store that the extension is going to be disabled for not following best practices.
Yeah, I’ve stared digging into it @holyjak. They got rid of some permissions, and when I went to dig in the code of Inspect is so old (v 2 of Fulcro) that I decided to upgrade it to Fulcro 3 while I’m in there. If you have any tips on getting shadow-cljs hot code reload to work I’d like to know…haven’t gotten to that step yet. Still porting old code. The porting was relatively easy, other than I forgot we used to use protocol-based network stuff, and all of that needs to change….also how you do background stuff seems to have changed. Yeah, any help you can provide would be useful. I’ll glance at your repo
No, sadly, my extension is JS-only. Here is the upgrade PR https://github.com/holyjak/Testofill-chrome-extension/pull/11 Already https://github.com/holyjak/Testofill-chrome-extension/pull/11/commits/898ac64890bd066a3570015d560cd6e9a273e54fdoes replace background events.js w/ a service worker . It does also some optional stuff, such as moving from callbacks to promises, which is not necessary.
I’d be happy to help.
Yeah, the bg thing….I need to do that, and I need to know what I should change from the bg code to make it a service worker… You could glance at the inspect code here and comment if you want: https://github.com/fulcrologic/fulcro-inspect/blob/manifest-upgrade/src/chrome/fulcro/inspect/chrome/background/main.cljs
I still need to rewrite the “remotes”, as I said, but this is the old background code
I noticed the same message, but seems to work.
Meh. Crap. I had not gotten a notice. Thanks for letting me know. You’re using the new one, and not legacy, right?
I’ll work on that
I’ve recently updated https://github.com/holyjak/Testofill-chrome-extension to conform with the new requirements (new manifest version only, etc.). Perhaps the same issue?
Yes using the newest fulcro extension, not legacy.