You are right that the built-in validator only checks the top-level form.

Here’s the thing: I don’t know if you want to validate edges, validate sub-elements, etc. I guess the assumption should be that you want to validate it all. So, at present the code needs expansion for the “default” validator to do all of that. I just make a single global validator using all-attributes of the RAD model and explicitly set that on my forms. A subform could be to-one and be a picker, but I guess in that case there would be no fo/subforms entry. If you want to write a patch that tries to walk the form set using the component options and looks for the subforms recursively and collects all of the attributes I think that would be ok.

So, I patched this in 1.5.1-SNAPSHOT

see if you like that better

https://github.com/fulcrologic/fulcro-rad/commit/12f7b612c19326851ba3a53193a6ab1e3360e58c

Thanks for noticing…I got used to just using my global one and never re-addressed it

:star-struck: This looks awesome, thanks a lot. I am trying it now but somehow it does not seem to make a difference. I suppose I messed up my environment and will keep trying 🙂 It works as expected from the REPL, when I run ((attr/make-attribute-validator (form/form-and-subform-attributes my.order-forms/OrderLineForm) true) my-captured-form-props) - it returns :invalid where before it returned valid. But in the app it still tries to save the form. In the console log I see

Form  my.order-forms/OrderForm  valid?  false
Form  my.order-forms/OrderForm  dirty?  true
:order/order-lines is not marked complete
:order/order-lines is not marked complete
:order-line/package-count is not marked complete
:order-line/product is not marked complete
Form is not valid because required attribute is missing: :order-line/product
Form  my.order-forms/OrderLineForm  valid?  false
...
Trigger [:order/id …#fulcro/tempid["#uuid "5cca09cf-0afe-4a03-8af6-fd82cb67066c""]TempId] :event/save
Activating state  :state/saving

Form is not valid because <some reason>
Activating state  :state/editing

I guess it does not fail b/c it skips checking the two :order-line/ attributes because the are not marked complete. That’s why com.fulcrologic.rad.form/valid? explicitly checks all-required-present? , but this check does not include subform’s attributes. Correct?

You're saying that fields that are only marked required, but that have no validator function themselves are a problem? Yeah, I didn't look at those, I just tried it where attributes had a valid? function

One of them (package-count) has valid? , the other (product) does not, and both have required? In this case, valid? is not even triggered I think b/c I have added a new order line to the order but have not touched any of its fields, so they are both nil/missing. That’s why the are both “no marked complete” as logged above.

Have you tried using the form debugger from the debug namespace?

Save really should not trigger unless everything is checked... So sounds like a bug somewhere

I tried it on the demo yesterday and it was working for me with the same structure you are describing on invoice

Ok, I'll dig in...

I am not sure what I do wrong. My OrderForm is marked as valid. When I look at its proposed-form-props from the :event/save there are some weird things:

::fs/config {
  fs/complete? #{:order/type :order/customer :order/order-lines}
  fs/fields #{:order/type} ; I guess ok since both customer and order-lines are subforms, not simple fields?
  fs/subforms {:order/customer {}, :order/order-lines {}} ; as expected
}
:order/order-lines {
  :order-line/id #fulcro/tempid[..] {
    fs/config {
      fs/complete? #{:order-line/package-count :order-line/product}
      fs/fields #{:order-line/package-count}
      fs/subforms {:order-line/product {}}
    }
    :order-line/id ... ; NO OTHER order-line property, neither count (expected, since unset?) nor the product ref
}}

defsc-form OrderLineForm 
  fo/attributes [r.order-line/product r.order-line/package-count]
  fo/field-styles {:order-line/product :pick-one}
  ...

defsc-form OrderForm
  fo/attributes [r.order/type r.order/customer r.order/order-lines]
  fo/field-styles {:order/customer :pick-one}
  fo/subforms {:order/order-lines {fo/ui OrderLineForm, ...}}
  ...

; with the key attributes
(defattr product :order-line/product :ref {ao/required? true, ...})
(defattr package-count :order-line/package-count :int {ao/required? true, ao/valid? (fn [value _ _] (some-> value pos?)), ...})
(defattr order-lines :order/order-lines :ref {ao/required? true, ao/cardinality :many, ...})

Interestingly, if I copy these very same captured props I explore above and try to validate them, I do get the expected invalid:

(def form-props {::fs/config {..} ...})
(def valfn (attr/make-attribute-validator (form/form-and-subform-attributes my/OrderForm) true))
(valfn form-props)
; => :invalid

If you change your RAD attributes and use hot code reload, then the validator might still have the OLD version of the attributes. Try stopping and starting the compiler, and reloading the page with the cache disabled to make sure you’re not getting stale things.