I am not sure what is happening.. In Console I can see > Form is not valid because required attribute is missing: :order/order-lines > Form ...order-forms/OrderForm valid? false > … > :order/order-lines is not marked complete yet when I click save, the form is saved (save-form goes over the wire, with :order/order-lines {:before nil, :after []} ). So 1. Contrary to what I wrote initially, RAD seems to detect correctly that the required to-many is missing and marks it invalid 2. Somehow, despite being invalid, save is not stopped What am I missing? 🙏

Actually I see in console valid? true now: > Activating state :State/saving > … valid? true > … dirty? true > :order/order-lines is not marked complete > :order/order-lines is not marked complete > … valid? true > … dirty? true > :order/order-lines is not marked complete > :order/order-lines is not marked complete > Trigger … :event/save-failed (Not sure why all lines are logged twice. The save fail thx to my backend check)

edge validation is tricky. By default form-state validators do not even check them (you have to ask it to). The generated form will have a validator based just on the attributes listed, but will not validated edges. You have to make your own validator and turn on edge validation to get what you want.

But you are right that the “naive” check from form.cljc should be updated to handle references better

Try 1.4.9-SNAPSHOT

I improved the default check

Awesome, thx a lot! Will try it ASAP.

Technically, the default validator should probably validate edges 😕

so that ao/valid? works as well

on to-one edges it isn’t necessary, but on to-many you might want to enforce a count

Problem is that’s a breaking change. Really both are, but only if you are relying on the bug. Always torn on how to fix these.

it isn’t a breaking change if you were using it “right”, but if you were relying on the bug it is…so I guess by the true definition it is not actually a breaking change even though it could break your application?

It's hard. Personally I prefer to disable incorrect uses, even if it can break something.

the fix i just did may not be right….but i know what to do

OK, I just pushed a new snapshot that has the following changes: • Refs are enabled by default on the validator generated for a form (if you don’t set one) • The required setting should work for refs now (with default settings) • The ao/valid? should also now be invoked for refs to allow checking things like the correct number of items in a to-many

let me know if that seems to break anything. If not, I’ll do a release

Will do

It works perfectly, thank you!

cool, yeah, I tried it out in demo and it does seem ok