Fork me on GitHub
#fulcro
<
2023-02-22
>
genekim05:02:04

I have a Fulcro RAD app based on the “fulcro-rad-demo” repo — but like a moron, I must have copied from another project, but didn’t grab the git history, so there’s no commits/branches before July 2022. (the initial commit is just my project code at that point in time.) And worse, I chose the wrong branch to copy — it’s using pathom2, not pathom3. Is there an easy way to somehow merge in all the pathom3 branch diffs into this repo? (Asking the question this way suddenly makes me think I could generate a “diff patch” from the “fulcro-rad-demo”, diffing pathom3 branch from the main brach. Is that the right approach, and if so, anyone know the command to do that? 😂) Thanks in advance!

Jakub Holý (HolyJak)18:02:45

It should be quite simple to switch from P2 to P3. Change the dependency, in auto-resolvers change the require to om.fulcrologic.rad.resolvers-pathom3 , in parser use com.fulcrologic.rad.pathom3/new-processor and compare manually the P2 and P3 differences in this ns. It even tries to make P2 resolvers into P3 ones, though I simply modified mine, it is simple too (use pco/defresolver and ::pco/output , notice that ::pco/input is not a set but []). On attributes use o/pathom3-(input|output|resolve) instead.

genekim01:02:31

Thanks as always @U0522TWDA ! I’ll give it a shot!

👍 2
zhuxun222:02:31

Is it intentional that link queries are included on the wire? Things like [df/marker-table '_] seem to appear in the remote queries

tony.kay02:02:27

I’ve never gone back and updated the default-global-transform, which elides things in the :ui namespace, to remove other things like this. Generally if you’re using pathom it will just not find anything and it’ll be fine. But yes, if there are things you’ll put in your queries that you need to not go over the wire, you need to update the global transform

zhuxun222:02:10

If I do not want this behavior, is the answer simply "write my own remote"?

tony.kay02:02:29

No, there is a global eql transform you can set on the app. Customize that to filter out whatever you don’t want.