fulcro 2023-01-13 | Slack Archive

greg01:01:48

I've been following the Fulcro video tutorials with Fulcro 3.6.0-RC3 and it looks it renders everything, not only the parents of the affected component. In comparison, the Fulcro 3.5.34 works correctly. I opened a ticket with screenshots and link to repo showing the issue: https://github.com/fulcrologic/fulcro/issues/526

tony.kay04:01:11

Thanks @grzegorz.rynkowski. Yes, it seems there was a regression. I’ve pushed 3.6.0-RC4-SNAPSHOT (sha aabd3ca9e7b25262aea4814a9c6e6a0f53746f7c). If anyone feels like testing that on a larger app to look for breakage I would apprecaite it. All the tests pass, and in my UI testing so far has not found any problems.

👍 2

greg11:01:04

I've found another problem in the new version. I posted it in the issue.

tony.kay15:01:49

Strange. It was definitely working for me. Try not setting the renderer

tony.kay15:01:35

And you have caching turned off on Chrome?

greg18:01:56

for (defonce APP (with-react18 (app/fulcro-app {})))

greg18:01:04

for (defonce APP (with-react18 (app/fulcro-app {:optimized-render! keyframe/render!})))

greg19:01:06

the option "Disable cache (while DevTools is open)" is ✅

greg19:01:22

The reproducible setup is available here: • repo: https://github.com/rynkowsg/fulcro3-yt-tutorial/ • branch: 230113-try-fulcro-rc4 More info in the issue comment https://github.com/fulcrologic/fulcro/issues/526#issuecomment-1381699079.

tony.kay23:01:49

I could not repro that in my own code, but I saw it misbehave in yours…possible compiler weirdness, the macro was misbehaving. I change the macro implementation and now it works for both.

Quentin Le Guennec10:01:38

Correct me if I’m wrong, but will-leave / allow-route-change? cannot be used to implement a (js/window.confirm) popup on route leave? That would require allow-route-change? to be allowed to side-effect.

tony.kay16:01:04

confirm is synchronous, so you can actually use it

2023-01-13

Channels