Ok. Thanks. I have a half-baked solution on the half-baked RAD implementation. I feel half-baked myself after working through this.

write a function like this:

(defn change-route-relative [{::uism/keys [app] :as env} router-actor new-route]
  #?(:cljs (dr/change-route-relative app
             (uism/actor-class env router-actor) new-route))
  env)

yes

Tony would accept a PR fixing it but I personally do not have time to look into it 😞

Ok. I may try to get the project spun up and work on fixing that if someone else isn't doing that already

There seems to be a 2nd regression as well - looks like the db tab is treating state as (seq {state stuff}) and goofing up when you click an index to add to watches

Scratch that last note --- not sure what happened, but that particular issue was just a fluke

I feel your pain. But the average user doesn't see it, maybe they believe Fulcro is a community effort and not the heroic deed of mostly a single person. Perhaps it would help to define an issue template or some pre-issue checklist that would summarize ☝️ and explain when (not) to open an issue?

Sorry, that’s all the time I’ve got for this. Not asking for a solution to people opening issues in the future. It’ll happen again no matter what I do. That’s OK. It’s normal. I’m doing something very unusual: Asking for people to do a bit of self-reflection in the “now”.

probably partly because this was the first thing that I saw when I woke up this morning, and perhaps I was a bit cranky 😜

FYI: There is even a hooks helper namespace: com.fulcrologic.fulcro.react.hooks https://book.fulcrologic.com/#_react_hooks_support

yup, although for useCallback we actually have access to that "sufficiently advanced compiler" the react docs mention and properly express its intent

it’s also worth noting that if you use timbre, you already have encore, and encore has a memoize that will GC and can have a TTL. It’s a much easier thing to use that gets you 95% there with no need to even “name” your dependencies.

dang. and I went to the trouble of making my own...

yeah, I think everyone should look through encore…there’s a lot of useful stuff in there

For instance, I’d like to use a RAD form to edit PersonDetails, like here: https://github.com/fulcrologic/video-series/blob/full-stack-over-time/src/app/client.cljs#L19 I can imagine implementing this by accessing the [:component/id :person-list :person-list/people], but how does one access this from inside a RAD form? (Question #1) I can also imagine using rroute/route-to or something to edit a specific entity, but how? (Question #3) Or maybe there’s a way to use RAD form functionality from within an existing F3 component (like PersonDetail), but how? (Question #2)

You mean this?

(form/edit! this TaxForm (uuid))

I can't speak to #1 yet, I've not tried anything like that to date. For #2, perhaps you are looking for formstate? https://book.fulcrologic.com#FormState For #3, you would want to look at the com.fulcrologic.rad.form ns, specifically create! and edit!

🤯🤯🤯. That's awesome — will check it out later today! Thank you, @U5P29DSUS !

form/edit! is awesome! That worked — thank you! But is there a way to use RAD forms for just one component (of potentially many) on the screen? Like in this marked up screenshot? (i.e., I’d love to leverage all the RAD form functionality like Save, Undo…)

now, this is something I'm curious about actually. I've been starting to toy with this exact bit of functionality. I haven't gotten far yet, but I think the potentially big issue is the fact that routers can only have one path target (correct me if I'm wrong please 🙂). To avoid that issue you would need to drop down a level in rad and do all the routing yourself, which may disturb some of the load code.

color me wrong 🙂. https://book.fulcrologic.com#_simultaneous_on_screen_routers

Maybe this just requires a bit of tooling in rad to make it easy?

In your e.g. you may still want manual placement control instead of a router though.

dang. I'll need to read the code to get my head around this fully. I'll let you know my findings if someone doesn't post the solution in the interim

This is so helpful — please keep me posted on your progress… I am currently trying to see if I can render it like a regular “defsc” component…. I’ll let you know how it goes.

(…I realize I may be doing something that exposes my total ignorance on how “defsc-forms” actually work.)

That is perfectly possible. I'm just not up to speed on what is(n't) required to make the life cycle work. AFAIK most of the form lifecycle is triggered by the router.

OMG. It totally worked!!! What sort of black magic has @U0CKQ19AQ created!!! Will post more later!!!

A form is a plain defsc component. It just adds routing integration and a state machine. If you want to use it anywhere, you just have to trigger the stuff that the routing would trigger. Trying my best not to tie you down with anything. Everything (I’ve thought of at least) has an escape.

The routing integration is a convenience, not a requirement.

This really is incredible, @U0CKQ19AQ!!!! The ability to have multiple RAD forms on the screen is so freaking cool, and makes it so easy to use the form machinery you've created! Is there a way to have a RAD Form access things like {:component/id :person-list} ? I'm trying to replicate some of the "video-series" examples you created with RAD, but can't figure out how to reach those "global state" things... Thx!!

@U6VPZS1EK please consider sending a PR to the RAD book to make it easier to discover form/edit! etc. Somebody (you?) could perhaps also write a section on "Using Forms outside of a router" 🙂 For reports it is perfectly OK to use them outside of a router but you need to start their UISM manually. I guess you just need to look at what the form/report :will-enter does.

> s there a way to have a RAD Form access things like `{:component/id :person-list}` ? ro/query-inclusions should work, provided you write it right, I believe. What does your look like? After adding it, look at the outgoing Network request - does the query look the way you expect? What about the response?

Will do in the next week, @U0522TWDA ! (And thanks for solving the mystery of why the form didn't look quite right... Looking at the screenshot, I noticed that it hadn't fully populated yet! Nice!)

@U0522TWDA Okay, I love that like ro/query-inclusions is likely the right mechanism! I had tried adding something like ro/query-inclusions [ [{:component/id {:person-list {:person-list/people [id, name]}] -- but it seemed like everything I put in resulted in nil everywhere. It should be an EQL query, which can be tested in Fulcro Inspector, yes? It occurs to me that I should have studied what the results of (comp/get-query) and (comp/get-ident) were. Will pick it up again tomorrow! Thx!!

that is wrong. You are trying to add a join on the :component/id property of current entity and there is no such thing, I think. Look at https://book.fulcrologic.com/#_link_queries

Also, Pathom knows nothing about :component/id so you don't want that at all in your query.

Hm, I have problems getting ro/query-inclusions working on latest rad-demo, it does not add it to the query sent to the backend... 1. I added ro/query-inclusions [:category/all-categories] to the RAD demo InvoiceList report 2. (comp/get-query com.example.ui.invoice-forms/InvoiceList) has the added part: [:com.fulcrologic.rad.report/id ... :ui/current-page [#:ui{:current-rows [:account/id ...]} ...] :category/all-categories] 3. (df/load! com.example.client/app :invoice/all-invoices com.example.ui.invoice-forms/InvoiceList) sends the query including the added part, like this:

[{:invoice/all-invoices
  [:com.fulcrologic.rad.report/id :category/all-categories]}
 :com.wsscode.pathom.core/errors]

[({:invoice/all-invoices
   [:account/id
    :invoice/id
    :invoice/date
    :account/name 
    :invoice/total]}) 
 :com.wsscode.pathom.core/errors]

[({:invoice/all-invoices
   [:account/id
    :invoice/id
    :invoice/date
    :account/name 
    :invoice/total]}) 
 :com.wsscode.pathom.core/errors]

Now I realize that also the query produced by df/load! is not what I expected (and I was wrong to expect it). Of course it puts the attributes into the join:

[{:invoice/all-invoices
  [:com.fulcrologic.rad.report/id :category/all-categories]}
 :com.wsscode.pathom.core/errors]

@U6VPZS1EK I thought more about it and perhaps I have the answer to #3. You use ro/query-inclusions . If the data is already in the client DB then you are good. If not, you need to df/load! them manually, e.g. as shown above. To access :component/id :person-list :person-list/people in this way you must remember that the query is relative to the report's position in the data tree (which is a subset of the ui tree). Only the Root can ask directly for {[:component/id ..] [..]} in its query. Any nested component must use https://book.fulcrologic.com/#_link_queries to reach it. So something like

ro/query-inclusions [{[:component/id :person-list] [:person-list/people]}]
;; or st. like:     [{[:component/id :person-list] (comp/get-query PersonList)}]

This is great, @U0522TWDA — I had intended to study your ro/query-inclusions example this weekend, but ended up spending 4 hours trying to figure out how to get the UISM machinery started for forms not started via router: https://clojurians.slack.com/archives/C68M60S4F/p1609404307479000?thread_ts=1609369557.443000&amp;cid=C68M60S4F > For reports it is perfectly OK to use them outside of a router but you need to start their UISM manually. I guess you just need to look at what the form/report :will-enter does. I tried using (form/start-form!) , and it took me a day to figure out where / when to call it. (I put it in the same place where the df-load! went.) My problem now: when I edit the form, the “Save” or “Undo” briefly flicker on, but then get disabled… Edits to the data show up outside the form, too… Movie of this happening here: https://www.dropbox.com/s/ogqoey8r9m58kbv/Screen%20Recording%202021-01-03%20at%2010.31.00%20AM.mov?dl=0 My current theory: something in the Form UISM was set wrong? Here’s the state from the demo app: Area of difference shown with a “<====”

- com.fulcrologic.fulcro.ui-state-machines/begin
 {:com.fulcrologic.fulcro.ui-state-machines/asm-id
  [:session/uuid #uuid "63827c18-5960-408f-8421-66d121a175b2"],
  :com.fulcrologic.fulcro.ui-state-machines/state-machine-id
  com.fulcrologic.rad.form/form-machine,
  :com.fulcrologic.fulcro.ui-state-machines/event-data
  {:action "edit",              ;;; <==== NOTE THIS:
   :id "63827c18-5960-408f-8421-66d121a175b2",
   :com.fulcrologic.rad.form/create? false},
  :com.fulcrologic.fulcro.ui-state-machines/actor->component-name
  {:actor/form :com.example.ui.session-forms/SessionForm},
  :com.fulcrologic.fulcro.ui-state-machines/actor->ident
  {:actor/form
   [:session/uuid #uuid "63827c18-5960-408f-8421-66d121a175b2"]}})

- (com.fulcrologic.fulcro.ui-state-machines/begin
 {:com.fulcrologic.fulcro.ui-state-machines/asm-id
  [:session/uuid #uuid "8a481331-eb1d-4e5b-9d19-759da23cb674"],
  :com.fulcrologic.fulcro.ui-state-machines/state-machine-id
  com.fulcrologic.rad.form/form-machine,
  :com.fulcrologic.fulcro.ui-state-machines/event-data
  {:com.fulcrologic.rad.form/create? false},   ; <===== NOTE THIS
  :com.fulcrologic.fulcro.ui-state-machines/actor->component-name
  {:actor/form :com.example.ui.session-forms/SessionForm},
  :com.fulcrologic.fulcro.ui-state-machines/actor->ident
  {:actor/form
   [:session/uuid #uuid "8a481331-eb1d-4e5b-9d19-759da23cb674"]}})

(…By the way, those state machine states come from the Fulcro Inspector Transactions…)

https://github.com/realgenekim/fulcro-rad-demo/blob/gene-experiments/src/shared/com/example/ui/session_forms.cljc#L107

i agree with your assessment

non-library applications should use :widget/id, readability is very important

I concur; with one caveat: If you expect your data store to be published for use in federated data system (i.e. you might pair up with other companies and use pathom to combine data sets in a federated graph) then it is quite useful and important to use the longer names. Most people are just building some in-house thing that doesn’t need to integrate that way, so the shorter name does create less mental overhead/work/aliasing

right, that's uncommon in my corner of the world but i'd expect it to be perfectly normal elsewhere... one way of having your short namespace and eating it too could be to map between short and full namespaces at the system boundaries (`:com.mycompany.widget/...` <--> :widget/...) but now you've got a mapping to maintain and the responsibility to make sure it's applied just where it's needed

yep…aliasing a lot of stuff creates way more headaches than having to type a little more during dev