Fork me on GitHub
#fulcro
<
2020-12-12
>
genekim07:12:58

Following up from my pairing session with @holyjak — I promised I would post something here for @tony.kay …. when we created a SessionForm that a had an UUID attribute, there was a somewhat cryptic Chrome console message. It wasn’t obvious which attribute was responsible for generating the error — it was the UUID field. (It would have been nice to get an error message like: “no formatter for :session/uuid (of type UUID)“. Screenshot attached.

holyjak07:12:33

Great you figured it out! Do you have the session/id in the list of the form attributes? I guess you should not because you don't want people to edit it...

genekim07:12:51

For sure, it probably doesn’t make much sense to have the UUID editable…. 😆 but I used it on the assumption that you’d get the same error for any UUID attribute.

👍 1
tony.kay01:12:33

You need to enable custom formatters

tony.kay01:12:20

they the error message would have been more understandable because it would have shown you the attribute details

tony.kay01:12:46

And yeah, there is no UUID form control…you’d have to make one, but that’s easy enough

holyjak17:12:16

You mean the bintray custom for matters for clojurescript in Chrome, I suppose?

tony.kay18:12:59

??? That was a bit of word salad to me, @holyjak

tony.kay18:12:22

Chrome dev tool settings, Console section, “Enable Custom Formatters”

tony.kay18:12:29

The deps include:

binaryage/devtools                  {:mvn/version "1.0.0"}
will automatically be able to format cljs objects in the console when that is enabled, which will be much easier on the eye in error messages.

holyjak18:12:31

Damn the autocorrection and not checking my text when in hurry! Sorry for that. Yes, that was exactly what I meant.

genekim07:12:19

@holyjak I spent some time tonight and feel like I almost got mutations working on SessionForm (that we were working on together), using what RAD autogenerated. I think I’m close! I had to change some schemas and dbs around, but now I get this error message: > D 20-12-12 00:58:10 _rad.database-adapters.datomic-cloud:- 98 - Saving form delta {[:session/uuid #uuid “60dd0f5e-7215-40ba-a110-3af30c40b7bf”] > {:session/speakers > {:before “Shaaron A Smith”, :after “Shaaron A Smith SSS”}}} > > D 20-12-12 00:58:10 _rad.database-adapters.datomic-cloud:- 99 - on schema :video > D 20-12-12 00:58:10 _rad.database-adapters.datomic-cloud:-100 - Running txn > [] > > E 20-12-12 00:58:10 _rad.database-adapters.datomic-cloud:-115 - Unable to save form. Either connection was missing in env, or txn was empty. > D 20-12-12 00:58:10 _rad.blob:-206 - Check for files to persist in {:com.fulcrologic.rad.form/id #uuid “60dd0f5e-7215-40ba-a110-3af30c40b7bf”, :com.fulcrologic.rad.form/delta {[:session/uuid #uuid “60dd0f5e-7215-40ba-a110-3af30c40b7bf”] {:session/speakers {:before “Shaaron A Smith”, :after “Shaaron A Smith SSS”}}}, :com.fulcrologic.rad.form/master-pk :session/uuid} The :video schema is correct, and the :before / :after vector is correct. But the txn vector Is empty. I tried calling manually some of the functions in com.fulcrologic.rad.database-adapters.datomic-cloud to see if I could get any insights on why the txn was empty— like wrap-datomic-save and save-form!… but again, my lack of understanding of how the underlying machinery worked impeded any real progress. Do you have any recommendations on an approach? (Your advice of hardcoding the UUID resolver result was awesome — is there some way to do something similar, so that I can perform a mutation event via the REPL, as opposed to going through the web client?). THANKS AGAIN! Latest working state is here: https://github.com/realgenekim/fulcro-rad-demo/tree/gene-experiments

holyjak07:12:37

Not sure, since the resolver is auto-generated.. I have to think on it

genekim08:12:11

Awesome — in the meantime, I’ll study how the rest of the RAD demo does mutations, and if needed, read up on mutations in the F3 docs.

👍 1
holyjak08:12:12

You could log the inputs coming to save-form! and wrap-datomic-save and compare them to those from a firm that works...

genekim08:12:33

🤯🤯 Roger that! Will do that first thing tomorrow. Thanks again!

holyjak14:12:07

https://github.com/fulcrologic/fulcro-rad-datomic/blob/develop/src/main/com/fulcrologic/rad/database_adapters/datomic_common.clj#L136 - perhaps log/store inputs of to-one-txn which I suppose is the relevant one. Also consider re-enabling debug logs. Especially this (and (schema-value? env schema k) (to-one? env k))

tony.kay17:12:53

Are you sure you put the connections in the env? You have to install the save middleware and give it a properly-written connection resolving function.

tony.kay17:12:10

(on the server)

tony.kay17:12:20

• All attributes have to have a ao/schema • All attributes have to be given to the save middleware • The schema of the database has to match the schema of the attributes you plan to save • The connection resolving function you supply has to provide a mapping from schema name to current connection.

genekim18:12:05

@holyjak @tony.kay Holy smokes, thanks for the help — after 2-3 hours of peeking into values inside of datomic-wrap-save and to-one-txn (using tap> and reveal), I finally discovered that the env / attribues didn’t have any of my session attributes installed… …because I forgot to add my Session attributues to the attributes vector. Another big face palm. But OTOH, this has given me about 5 hours of exploration into how underlying machinery works. A bit embarrassed that I could have fixed it without even leaving my session.cljs file… But, feeling AWESOME THAT MY FORM SAVE WORKS!!! 🎉🎉🎉.

bananadance 1
tony.kay18:12:43

yeah, it is unfortunate I don’t have more time to document…right now you have to kind of carefully comb over each bit of demo to make sure you understand why each thing is done, and if you need it in your circumstance

genekim19:12:22

It’s all good — I’m taking lots of notes, and planning on writing exactly what the steps required are to get my reports and forms working… …and what any surprises were… One of them is definitely what you said: it’s all surprisingly simple, with values being flowed through all the machinery. I think the missing thing is just showing what the major components are, and how they fit together — I’ll share with you whatever I come up with sometime today. Great work on Fulcro RAD. I think it definitely can achieve a “Ruby on Rails” level of magic — meant in only the most complimentary way, of course! 🙂

❤️ 1
genekim19:12:14

(I’m also writing up what dynamic changes can be made w/o restarting anything (datomic-common), and for those that can’t, what exactly is required to be restarted (entire server, server + middleware reload, etc.) That was a source of some frustration, because until today, I wasn’t being very methodical about taking notes, and so kept wondering why my code changes weren’t being reflected. 🙂

tony.kay19:12:30

There’s a new call that you can make that should update queries on hot code reload…which is a big improvement, but you have to call it in the reload that shadow calls

tony.kay19:12:33

not sure if that is in demo

tony.kay19:12:01

It is: (comp/refresh-dynamic-queries! app)

tony.kay19:12:42

without that (before the remount) queries won’t update….of course initial state is a hard reload (technically you could fix that at the REPL as well, but it would disrupt current app state)

genekim19:12:12

Awesome! By the way, is there a way to test the mutation/save to database without having to use the web client? Currently, the only way that I know how to test if models are correct is logging in, navigating to forms in client, edit, update value, save…. 🙂

tony.kay19:12:52

certainly, you can just call the parser with a save mutation in CLJ, OR you can use the save-form! from the form ns on the server and hand it a diff

tony.kay19:12:55

In fact, that’s the easy way to write mutations that need to do something on server when it isn’t a form…write it up as a form diff and hand it to save-form!

1
tony.kay19:12:04

writes across all databases automatically 🙂

genekim20:12:46

🤯🤯 Wow! Okay, will give that a try! I know what form diffs look like now! 😂😂

genekim20:12:26

That is so cool. Oh and one more question! 😃😃 Can you point to an example or idiomatic way to have a button that when pushed, tells the server to run a function (eg, do a REST call to an external API): take this session info and update it via the Vimeo API) I see examples of triggering arbitrary actions on the JavaScript client, but not how to call something on the Clojure server.) Thank you!

tony.kay23:12:14

You mean on a report or form? The controls section. Just make a control button, and have the :action run a full-stack transaction (or do whatever)

tony.kay23:12:45

you can do that on row action buttons or in control sections.

tony.kay23:12:24

If you actually mean you want to talk to REST, you could do an http-client thing, or you could make a Fulcro remote that adapts REST API to EQL.

tony.kay23:12:57

the http-client thing is “ok”…the callback would just call something like Fulcro’s merge-component to put the data in the database.

tony.kay23:12:30

The “idiomatic way” is to hide that behind a formal remote…you can make a client-side pathom parser that handles that

genekim00:12:20

Got it! I will try to figure out how to make a button in a report or form, and use a control :action to run a function on a server. FWIW, I managed to write a YouTubeVideo set of resolvers in 45m (mostly finding all the right places to record attributes), a corresponding report in 10m, a form in about an hour (mostly hunting down namespaced keywords I forgot to change)… An order of magnitude faster than last time around! This is definitely worth the investment of time it required to learn! (I’ll write up the cookbook I came up with. I’ll be referring to it all the time. Maybe I’ll put it into a public Google Doc…)

❤️ 1
holyjak13:12:06

Question about https://github.com/fulcrologic/fulcro-inspect#using-the-fulcro-3x-electron-app - where are the ns com.fulcrologic.fulcro.inspect.websocket-preload and com.fulcrologic.fulcro.inspect.inspect-client (with install-ws) defined? I guess they must be visible to shadow-cljs for the preload / fn call to work yet the instruction say not to add the inspector to the project dependencies. And I do not see them in https://github.com/fulcrologic/fulcro/tree/develop/src/main/com/fulcrologic/fulcro either. So how is this supposed to work? Thank you!

tony.kay17:12:18

Adding inspect to the classpath is a bad idea because it is written in F2, which would then confuse the heck out of you by getting offered the wrong nses on autocomplete. Back in the f2 days client was (and still is for f2 users) part of inspect. With the f3 renames, that was not desirable (nor was it ever necessary).

holyjak19:12:50

I guess I do something wrong

(require '[com.fulcrologic.fulcro.inspect.inspect-client :as ic])
=> nil
ic/install-ws
------ WARNING - :undeclared-var -----------------------------------------------
 Resource: <eval>:1:1
 Use of undeclared Var com.fulcrologic.fulcro.inspect.inspect-client/install-ws
--------------------------------------------------------------------------------
Or is Fulcro 3.2.12 too early?

tony.kay19:12:12

always assume an older version is possibly out of sync w/docs

tony.kay19:12:27

I don’t have a clear memory of that…use the source, Luke 🙂

😂 1
holyjak19:12:28

thank you. I will finally go and upgrade.

holyjak19:12:59

Latest RAD is 1.0.8 which depends on Fulcro 3.2.17 while latest Fulcro is 3.4.10. I guess it is save to upgrade to 3.4, right?

tony.kay19:12:25

if you’re on 3.x, I’d always just use the latest

tony.kay19:12:18

I do use break versioning for the major number, because sometimes you just get in a corner…but the other two numbers are purely about “amount” of addition/improvement, and should be non-breaking

tony.kay19:12:25

Fulcro 4 would likely be a new beast altogether, and would not technically break 3, it just would use new names for things but might be API-like…I have no current plans for such a thing, and am pretty happy with where the base design has gotten. There is plenty that could be added, but none should break

tony.kay19:12:56

So, the major number is sorta hedging my bets

👍 1
holyjak21:12:24

Turns out the docs were wrong, a fix is here https://github.com/fulcrologic/fulcro-inspect/pull/96 //cc @U6VPZS1EK

🎉 1
alex-eberts19:12:44

I’m building a UI with fulcro’s semantic-ui.factories and so far it’s been a good experience. However, I’ve run into a couple issues: My original idea was to wrap semantic-ui factory in defsc to get the benefits of semantic-ui combined with fulcro’s state management but unfortunately this causes rendering issues. To solve the rendering issues, I separated the state management into a defsc and then I’ve wrapped the factory in a regular defn and the rendering issues appear to be solved. My question : Is there a better approach to combine semantic-ui.factories with defsc without having to create a separate defn to handle rendering? Project code: https://github.com/aeberts/fulcro-rad-demo/blob/054d81b95592e1d9d69e8fb3e7eed89efb3cae53/src/shared/com/example/ui.cljc#L58

tony.kay20:12:22

Part of the reason I picked SUI to begin with is that the library provides real controlled components out of the box. I’ve never felt the need to wrap them “generally”, as they are almost always used in conjunction with a form, which can be a defsc easily enough. The primary exception is dropdown, which I’ve wrapped in order to do type conversions…see RAD’s semantic ui plugin entity picker.

tony.kay20:12:02

In specific answer to your question: Anything you put in a defsc that has data deps MUST query for them, or Fulcro will not update them. There are no other specific restrictions. “rendering issues” is rather vague, so I can’t say much more than that

alex-eberts20:12:10

Thanks Tony - I’ll take a look at the semantic ui plugin entity picker and the RenderingOptimizations section.

holyjak20:12:44

The problem Alex had was that he is nesting two SUI components, Sidebar and MenuItem. If he wraps the menu item in a defsc then it breaks the look and feel, presumably because suddenly he has Sidebar > FulcroMenuItemWrapper > MenuItem instead of just Sidebar > MenuItem and something in SUI expects M.I. to be a direct child of the Sidebar.

alex-eberts21:12:36

Thanks for the clarification @holyjak! 😉