Thanks for the patches. published update book

My pleasure

There is a #js in com.fulcrologic.fulcro.components/factory for which there is a custom data_reader for the clj environment. Seems like the analyser can’t deal with it.

@tony.kay have you discussed ☝️ with #cljdoc or should I ask for possible solutions there?

I have…I’ve given up on cljdoc

it just didn’t support enough general cljs, and it was eating my life trying to get it to work. I’m done with it. You’re welcome to try

But I’m tired enough of it that it is officially unsupported 😉

Ok, understood. Thank you!

Is the underlying problem that it tries to analyze cljs code from Clojure? Do you perhaps have examples of other issues you experienced? Or perhaps I can just search #cljdoc archive for your messages?

yeah, search. I don’t remember, but I did ask abt it. Basically if you do anything remotely unusual in cljc or cljs, it can’t handle it

So, I’m thinking: it’ll magically start working some day, and is “some else’s problem”

I don’t want to have to worry about it every time I push a release

I understand. I will see what can I do.

How about you pass all functions as computed-props to the child?

Can we go with a 9? I don't want a matching stroke, and I'm doing the same for autogenerated forms

This is a normal React pattern: callbacks, as @mroerni said. You don’t code a transaction for the parent’s data IN a child. That is a broken abstraction. You pass something like onClick or onDelete in computed props, and code the transact IN the parent.

https://book.fulcrologic.com/#_passing_callbacks_and_other_parent_computed_data

A parent MUST know something about children (because it lays them out, and gets thier props), but a child should not be explicitly coupled to knowledge of the parent. Technically passing this does not break that abstraction, but as soon as you use it, I bet it does…because you’re going to do things like call mutations (parent-thing-delete) (which can imply the type of parent, or introduce a type dependency)

Indeed, this little thing was more of an intellectual challenge. However, I typically have a quite a lot of grandchildren somewhere which have well-defined behavior and whose mutation also act on some "main" parent. They are specific enough to have the ident of that parent in their query or passed as props and act on their own. I consider that most of the time, a child should not know the exact type of its parent but it sure can expect it to conform to some contract. A child knows in what context it is supposed to be used.