RAD progress: I got quite a bit of File Upload working in RAD today. It needs a lot of refinement, but it already allows for selecting a file, uploading it sideband while they continue to edit the form, tracking upload progress, and fixing up the form values on save.

Question: why in the live routing example (#37 in developer's guide) do you not need to use an element factory on Main and Settings? I see that they are not composed into a tree in code explicitly so does the router do this behind the scenes?

@looprecur you don’t need to make factories…the router makes its own…just an oversight in book

I have a smart template in my editor that makes a new defsc and factory in code if I just type class name…just forgot to delete the factory.

Okay, thanks!

Is :will-enter a good place to check for an active session, and is this a reasonable way to do it?

{:will-enter (fn [app {:keys [id] :as params}]
               (let [editor-ident [:component/id :editor]
                     session-valid? (get-in (fapp/current-state app) [:component/id :session :session/valid?])]
                 (if session-valid?
                   (dr/route-deferred editor-ident ...)
                   (dr/route-deferred editor-ident
                     #(do
                        (dr/change-route app ["main"])
                        (dr/target-ready! app editor-ident))))))}

Remember that will-enter can be called multiple times during route resolution (search for matching route)

perhaps not the best name…should prob be called “might-enter”

so as long as the code is idempotent in nature it is prob ok

I would tend to put security about session in my own nav-to kind of function. If you want to co-locate data/lambdas related to it on targets, then just add that to the options map of the compinent under new nsed keys

well it’s just doing a read on the global app state … 3 times … maybe it’d be better to check in the URL parser before change-route even gets called the first time …

yeah, I guess if you’re coming from strings it might make sense to use will-enter now that you say that

yeah, the only thing before :will-enter is my pushy URL parse code

Is there a way to look up a component based on the route str vector? dr/route-target? Yes, this works from my URL parser to get the component options and I’ll add an entry to check if it needs auth:

(comp/component-options 
  (:target
    (dr/route-target
      (comp/registry-key->class :riverdb.ui.root/TopRouter)
      ["sitevisit" "edit" "123"])))

oh no actually that just gets the top level route target …

@tony.kay Is the function delta->datomic-txn supposed to handle Fulcro tempids well, or is that something that might need to be improved, or am I thinking about it the wrong way? I can come up with a specific failing example, just wanted to ask the general question first.

@thosmos will proposed-new-path work for you?

it returns idents of targets…you could use that as a starting pt to make whet you need

the logic in change-route-relative is what you really want: find the target…could factor that out

I’ll take a crack at factoring out the find algo

There is a TODO in that ns…a lot of that logic is duplicated in two places already I think

and would be nice as a top-level fn…just didn’t want to fiddle with it and break things 😛

yeah I saw that message. if I get something working I’ll maybe see if it works for those

guess I have enough running on it now and tests that I could fully test it and feel comfortable