Fork me on GitHub
#fulcro
<
2020-02-18
>
Chris O’Donnell00:02:05

@tony.kay Do you know the status of the sql fulcro-rad adapter? Looking at the github repo, I don't see any commits since late december. I would be interested in helping to push that effort forward if the previous maintainer doesn't have time for it anymore.

davewo01:02:05

funny you should ask 🙂 Today I got an intro to the work in progress from the previous contributor. So progress has resumed but it might be a week or two before anything visible/useful pops out. If you have a special place in your heart for this work, I could direct my efforts elsewhere. @tony.kay for visibility.

Chris O’Donnell01:02:16

Excellent, glad to hear that. 🙂 I don't need to be the one pushing this along; I'm more interested in seeing the "end product" made a reality. Please let me know if there's anything I can help out with.

davewo01:02:06

Thanks @U0DUNNKT2, will do.

👍 4
Aleed00:02:16

how do you turn guardrails off with shadow-cljs? when releasing my shadow-cljs app I'm seeing this error: ExceptionInfo: REFUSING TO COMPILE PRODUCTION BUILD WITH GUARDRAILS ENABLED!. i have the same configuration shown in fulcro templates, basically only my :dev build has :compiler-options {:external-config {:guardrails {}}} , and my :release build is empty.

tony.kay16:02:04

@alidcastano did you figure it out?

tony.kay16:02:19

is also should tell you why it was enabled? (jvm prop vs config file)

Aleed17:02:07

yep, you pointed me to right direction. I had it enabled in my deps.edn :dev alias, and shadow-cljs was always picking up the alias

Aleed17:02:18

though I imagine the fulcro templates have the same problem

Aleed17:02:18

since the {:aliases [:dev]} shadow-cljs configuration is done globally

tony.kay17:02:40

ah, yeah, that’s a problem

tony.kay17:02:35

actually, it’s not. I don’t enable G.R. in the dev alias in deps

tony.kay17:02:25

The reason I use a JVM property is that you can set them via command-line -D, which means I can easily put that in my CLJ REPL startup instead of a config file. So in IntelliJ I have that just in JVM args for a particular run config.

tony.kay17:02:36

Glad I added that exception on release builds, though…you don’t want G.R. in those…we kept getting bit by accidentally having it enabled (had a pre-running shadow with the option set, do a release build, it connects to running server and screws up).

Aleed17:02:29

so this is the line I commented out to get my web release working: https://github.com/fulcrologic/fulcro-native-template/blob/943ddc822bcaf29fb38c98e0873c1e22e98dcedf/deps.edn#L35 i think it's what you're referring to as the JVM property, but it's what's causing the error so it does seem to be causing G.R. to be included and yea, glad to see that exception there too 🙂

tony.kay20:02:30

oh, the native template…didn’t look at that on. Yeah, send a PR…should not be there

Aleed20:02:37

sure, here ya go https://github.com/fulcrologic/fulcro-native-template/pull/7 ty for helping to figure out issue

fjolne20:02:34

ugh, that was my PR which added GR to jvm-opts, but AFAIR GR didn’t work in native if passed through shadow config... anyway, it certainly doesn’t belong to jvm-opts, better still to pass directly to shadow cli hopefully i just screwed up and it would work fine any way though

Aleed21:02:36

oh well tbh I haven't gotten to using native yet, I was just setting up my fulcro project based on that template. so not sure what the workaround would be to getting GR to work in native

tony.kay04:02:11

hm @alidcastano, you sure you don’t have it enabled in jvm-opts?

tony.kay17:02:43

Fulcro 3.1.13 released with slightly improved multi-root support according to feedback from @mdhaney

metal 24
tony.kay17:02:57

verified to work with vanilla js lib React Navigator