So I'm still trying to solve my problem. I have gotten much further -- I now have the optimistic update working. However, my mutation code returns:

"Transmission was aborted because the request middleware returned nil or threw an exception"

(defmutation add-person
  "Mutation: add a new person with ':person/name :person/age' to the list with ':list/id"
  [{name    :person/name
    age     :person/age
    list-id :list/id
    tempid  :tempid}]
  (action [{:keys [state]}]
          (swap! state assoc-in [:person/id tempid] {:person/id tempid :person/name name :person/age age})
          (swap! state update-in [:list/id list-id :list/people] conj [:person/id tempid])
          (js/console.log "state=" state))
  (remote [env] true))

(pc/defmutation add-person [env {name    :person/name
                                 age     :person/age
                                 list-id :list/id
                                 tempid  :tempid}]
                {::pc/sym `add-person}
                (log/info "Adding person" name age "to list" list-id)
                (dosync
                  (let [person-id (get @people-table :next-id)]
                    (swap! people-table assoc person-id {:person/id person-id :person/name name :person/age age})
                    (swap! people-table update :next-id inc)
                    (swap! list-table update list-id update :list/people #(conj % person-id))
                    {:tempids {tempid person-id}})))

@hadilsabbagh18 So, your code looks pretty much right

what is the return value of dosync? I don’t remember…if it isn’t serializable, then that is your problem

you’re getting a middleware exception on the server or client? you didn’t say where that exception was

Hi @tony.kay. dosync returns the last statement. The middleware exception is on the client. The log statement on the server does not get executed.

Are you passing anything strange in as parameters? What is you call to transact! look like?

the middleware is pretty robust, but it won’t tolerate anything that cannot be transit encoded

and how did you configure your app remote? Did you customize it at all?

See also: There is a new algorithms ns called normalized-state…it has a swap!-> macro that is super nice for doing multiple steps in a mutation FYI

@tony.kay Here is my transact! call:

(defsc AddPerson [this {:person/keys [id name age] :as props}]
  {:query [:person/id :person/name :person/age :list/id :tempid]
   :ident (fn [] [:person/id id])}
  (let [tempid (fulcro.tempid/tempid)
        new-person {:tempid      tempid
                    :person/id   tempid
                    :person/name "Mom"
                    :list/id     :friends
                    :person/age  76}
        add-person (fn []
                     (comp/transact! this [(api/add-person new-person)]))]
    (ui-button {:onClick #(add-person)} "Add Mom!")))

strange…the default http remote middleware is set up to support tempids

I was just using them today

how is your mutation defined?

oh I see it above

nvm

any more details on the exception?

It is in the Fulcro inspector as an entry in the local database. The console just says cannot write.

ah, cannot write sounds like a transit problem…any weird deps in your project?

perhaps a screwed up version of transit is in your deps

transitively

Let me check into that. Thanks @tony.kay! I appreciate the late night help!

try adding "transit-js": "0.8.861" to your package.json

there is a weird bug I remember transit having with respect to something…I don’t remember what…but I think that might fix it

then do your npm install and clean/restart shadow-cljs

(rm -r .shadow-cljs, and generated js files, just to be safe)

I’m about done for the night…but I’m betting that will fix it

Thanks again @tony.kay

@hadilsabbagh18 interested in knowing if that fixes it…you could also try setting the version of transit-cljs in your deps.edn if it isn’t there

Ok. I will try that also.

The npm did not fix the problem.

also, what version of cljs? If you’re using “latest everything” it might be something in some new version of something

adding transit-clj also did not fix the problem. I am using shadow-cljs 2.8.83 and clj 1.10.1

Shoould I use the deps.edn and other config files from the example git repo?

@hadilsabbagh18 Always start with a known good config on deps and package.json

you can update to the latest version of Fulcro, get your app working, then try bumping other deps

Ok. I'll try that.

is there a way of adding some metadata on the server side to a query result like (with-meta results {:result-count 42}) ? I was about to add a :query-count key to all queries for this, but I just realized it can possibly be done with metadata? Or does that not cross over the wire?

or should I do a separate query just for the meta info?

metadata does not go on the wire (I think you can enable that in transit, but I don’t have it). You can always use a namespaced key…open maps are your friend.

@hadilsabbagh18 you also have cache turned off in Chrome browser while in dev mode?

make sure you’re not getting old versions of files

Let me double-check

I do have cache turned off in Dev mode.

@tony.kay I am going to bed. Will pick this up in the morning. Thanks for all your help!

welcome

@tony.kay I suppose the problem with adding a key to something that returns 100 results is that the key is repeated in all records and it would pollute the DB. not a big deal i guess. or I do some strange thing like return an empty record with just the meta keys, etc, but it all sounds hacky. If I wanted to turn on metadata support in transit, would that be doable in the transit wrappers on both side?

don’t know off the top of my head…you’d have to look

not sure it supports it at all…might be thinking of edn encoding

@thosmos you may also be prematurely optimizing…is it really that much space in today’s memory terms or even network speeds?

hehe, ssshhh I’m actually using this to avoid other things ;)

ah…got it

but good point, I think I’ll just make a separate query just for one row of metadata

that’s how the old system does it in graphql that I’m replacing

apparently transit supports it, just need to turn it on. I think it’s a cool feature to have for queries, because pagination uses total number of results before the filters are applied

cool, well, might be fun to play around with…let me know if you get good results

I think I’ll try getting it to work with the template app and will send you a PR if it seems worthwhile (and if I actually get it working)

So I made a successful test of passing metadata from server to client DB. It’s a one-liner: (wrap-transit-response {:opts {:transform t/write-meta}})

Ah, but it breaks something in session auth. will need some more work apparently

@tony.kay Regarding passing the req to parser env: its no trouble for me to reimplement wrap-api, and I should probably do that until my work stabilises - to your point about knowing what else I need.. thanks very much for commenting.

Hi all, I am getting this error at the moment in my Fulcro app: Uncaught TypeError: Cannot use 'in' operator to search for 'fulcro$isComponent' in true and I am not quite sure what it causes this.

any hints?

Perhaps you are not passing this (or app) as first argument in a call to comp/transact! . Just a guess...

I’m not sure what’s happening, but from time to time dynamic routers stop passing props to its targets and the only way to fix it is to literally clear all the caches (shadow-cljs + build). Anyone hit this behaviour? I have browser caches off + hit force refresh every time anyway.

Ah, I guess the problem is in defsc macro: I moved the target component from one ns to another, so might be that it somehow persisted in both of them. I recall cljs macros not updating unless one cleans the build.

ta, I'll check it out

@thomas you are passing a boolean where a component is expected, I think. The field fulcro$isComponent is a hidden field on components. A function tried to access it, but it found that instead of a js object it found the value true.

yes, but the weird thing is that it works sometimes... when the value is false I don't get the error.

only when it is true

This particular kind of error message is common in the clj(s) ecosystem: TypeError cannot X on/in Y…in this case X is “use ‘in’ operator to search for ‘fulcro$isComponent’” and Y is “true”

probably code that says something like (and component (component? component))

(internally)

I do that a lot to prevent NPE when ppl nil pun

but it doesn’t help if you “boolean pun” 😜

Thank, I'll continue later with this.

In case somebody else hits this issue: dynamic router should be elided from parent component query or else its props will get swept from that component, so it could not initialize properly (but otherwise would look ok). Spent like a few hours on this…

???

what do you mean elided from parent component query…that is incorrect

Elided for network requests, sorry

you have to compose router into your app just like any other component

ah

hm….I should beef up the default global eql transform to include that and the form config join

in general you don’t “load” routers, so it isn’t an issue

Well, in case of the router it’s enough to just have it with ui namespace

I usually did it this way, but forgot in one place and that was a nightmare to debug

Hi @tony.kay. I think there is an issue with transmitting tempids. I have instrumented the client and server with debug-handlers (which returns a function that prints its arg and passes it on). I have replaced the tempid with an integer and the network problem goes away.

@wilkerlucio can you (or anyone else) think of any reason not to elide com.fulcrologic.fulcro* keys from EQL in network requests? I’m thinking I should make the default eql transform remove those in addition to UI kws, and I can’t think of any problems that will cause.

@hadilsabbagh18 I can take a look…I have been using UUIDs a lot lately, but I’d be surprised if tempids are broken, but I would not be surprised if your deps were screwed up and transit was generally broken for your project.

@tony.kay I can't think of a reason either, but I appreciate if it can be disabled (in case we realize some need for it in the future)

@tony.kay. You are probably right.

@fjolne.yngling I’m pushing 3.0.16-SNAPSHOT to clojars that has a new default eql transform that removes those keys from net queries. @wilkerlucio that transform is already configurable, so it is easy to override.

to save me some time: is anyone else using Fulcro tempids on network requests with Fulcro 3?

if we have confirmed “it works for me” I’ll not go looking

sorry, not 16 snapshot

will be 17 snapshot

@hadilsabbagh18 I’m running the todomvc project that lives in Fulcro as a test project. It uses tempids, and is working perfectly. The deps tree for the project is:

org.clojure/clojure 1.10.0
  org.clojure/core.specs.alpha 0.2.44
  org.clojure/spec.alpha 0.2.176
com.fulcrologic/guardrails 0.0.9
  expound/expound 0.7.2
edn-query-language/eql 0.0.9
  org.clojure/test.check 0.10.0-alpha3
com.taoensso/encore 2.115.0
  com.taoensso/truss 1.5.0
  org.clojure/tools.reader 1.3.2
cljsjs/react-dom 16.8.6-0
com.cognitect/transit-cljs 0.8.256
  com.cognitect/transit-js 0.8.846
org.clojure/clojurescript 1.10.520
  org.clojure/data.json 0.2.6
  org.clojure/google-closure-library 0.0-20170809-b9c14c6b
    org.clojure/google-closure-library-third-party 0.0-20170809-b9c14c6b
  org.mozilla/rhino 1.7R5
  com.google.javascript/closure-compiler-unshaded v20180805
    com.google.jsinterop/jsinterop-annotations 1.0.0
    com.google.javascript/closure-compiler-externs v20180805
    com.google.guava/guava 25.1-jre
      com.google.errorprone/error_prone_annotations 2.1.3
      org.codehaus.mojo/animal-sniffer-annotations 1.14
      com.google.j2objc/j2objc-annotations 1.1
      org.checkerframework/checker-qual 2.0.0
      com.google.code.findbugs/jsr305 3.0.2
    args4j/args4j 2.0.26
    com.google.protobuf/protobuf-java 3.0.2
    com.google.code.gson/gson 2.7
cljsjs/react 16.8.6-0
com.taoensso/timbre 4.10.0
  io.aviso/pretty 0.1.33
com.cognitect/transit-clj 0.8.313
  com.cognitect/transit-java 0.8.337
    commons-codec/commons-codec 1.10
    com.fasterxml.jackson.core/jackson-core 2.8.7
    org.msgpack/msgpack 0.6.12
      com.googlecode.json-simple/json-simple 1.1.1
      org.javassist/javassist 3.18.1-GA
    javax.xml.bind/jaxb-api 2.3.0
cljsjs/react-dom-server 16.8.6-0
cljsjs/socket-io-client 2.1.1-0
org.clojure/core.async 0.4.474
  org.clojure/tools.analyzer.jvm 0.7.0
    org.clojure/tools.analyzer 0.6.9
    org.clojure/core.memoize 0.5.9
      org.clojure/core.cache 0.6.5
        org.clojure/data.priority-map 0.0.7
    org.ow2.asm/asm-all 4.2

Note the transit versions. This is generated with clj -Stree.

Thank you @tony.kay. I will fix my deps accordingly.

@tony.kay what does your package.json look like?

https://github.com/fulcrologic/fulcro

it’s right there in the project

open source and all 🙂

but a lot of that stuff is overkill for a basic project

some of it isn’t needed by Fulcro since I moved the book to a new repo

I will just go with your website. Thanks @tony.kay

Hi @tony.kay. I believe I have uncovered my problem. I followed the book but it still has Fulcro 2.8 references. In particular, fulcro.tempid is 2.8. What should I use for Fulcro 3?

Oh, you have Fulcro 2 and 3 on classpath? I highly recommend you fix that

Fulcro 3's is in com.fulcrologic.fulcro.algorithms.tempid/tempid

I should have seen that…I assumed your code had an alias

I now have only Fulcro 3. thanks @tony.kay

glad it wasn’t a deps problem on transit…that was worrisome

book updated. The ns list at beginning did list the ns, but the code in examples used the wrong alias

where else in the book do you see tempid errors?

Hi @tony.kay. Everything works as expected now. I appreciate your efforts in helping me, I know you are busy.

welcome…I knew the “having both on the classpath” issue would bite some ppl, which is why I’ve gone to quite a bit of trouble to help ppl avoid it by even making a fork of workspaces that is f3 only. It’s OK for them both to be there, but they are not compatible with each other, as you found

Hi All... still a bit confused here... I have a query for a value and I destructure the keys as well. I can see the value in the Fulcro Inspect tools (great tool BTW). but the value is null when I print it 😞

so I must be doing someting wrong... but I am not sure what though :((((

I'm playing with the react native fulcro 3 template but can't get the fulcro inspector electron app to connect to the mobile app in the simulator, how do I debug that?