Fork me on GitHub
#fulcro
<
2019-09-04
>
tony.kay00:09:04

OK, so I don’t know if they are better or worse in terms of content, but the audio is at least non-corrupt (I hope). I was able to do new videos in a single take with minimal background noise. I also recorded a third one I’m uploading now. The videos available are now: - Getting started : minimal project setup, shadow-cljs, and a few IntelliJ tips - Normalization : A tour of how Fulcro normalizes data (both the format, and the internal mechanisms) - Initial State and Mutations: How we get the initial “frame” of data into the database for application startup, and the basics of how mutations are encoded and used.

60
4
tony.kay04:09:27

sorry, you’re going to have to point out what you think I’m supposed to be looking for..dumping more that 2 lines of data generally is not something I have time to sift through

bbss02:09:08

Oh, right sorry about that. It's that fs/dirty-fields returns dirty fields as I expect (and use to send as diff for back-end :)) but fs/dirty? doesn't say the form is dirty..

currentoor05:09:21

@U09MR0T5Y it could be a bug, it would be very helpful if you could come up with a minimal example in a gist

currentoor05:09:30

this is still pretty noisy IMO

bbss05:09:45

Okay sure

currentoor05:09:54

thank you i appreciate that

currentoor05:09:41

i’m currently adding a feature to fs/dirty-fields if there is a bug i can add it to my pull request

bbss05:09:57

alright, I'll get right on it.

currentoor05:09:51

here are the specs for dirty fields

currentoor05:09:14

something minimal and easy to read like that will go a long way

bbss05:09:07

I thought that fs/dirty? and fs/dirty-fields operate on plain data, but it seems it uses meta or walks the state-map form-state because my snippet example seems to not (entirely) reproduce the problem.

bbss06:09:07

@U09FEH8GN I think this demonstrates it. Does this miss required steps?

tony.kay14:09:30

@U09MR0T5Y where is add-config?

currentoor16:09:57

For the moment you could define your own dirty? function in terms of whether dirty-fields is empty or not

currentoor23:09:22

ah i see the bug is when a subform entity is added or removed, fs/dirty? incorrectly reports false

currentoor23:09:22

i’ve added a failing test and am working on a fix

currentoor00:09:59

@U0CKQ19AQ i’m wondering why we don’t define fs/dirty? in terms of fs/dirty-fields?

currentoor00:09:26

there’s a small performance overhead but that’s the only downside i can think of

currentoor00:09:30

ok i did exactly that, otherwise i would have had to duplicate some of the core recursive logic in fs/dirty-fields

currentoor00:09:37

it’s in the the PR

currentoor00:09:04

IMO this should probably be back ported to fulcro 2

currentoor00:09:28

FYI we were doing something similar ourselves in our UCV project

bbss01:09:20

Okay good to know it was a bug, thanks!

currentoor01:09:46

@U09MR0T5Y thanks again for the small reproducible snippet, that always motivates us to fix things quickly 🙂

bbss01:09:28

yw, really loving fulcro, things are coming together nicely lately and in big part thanks to fulcro.

currentoor02:09:01

that’s good to hear!

currentoor03:09:45

3.0.0-beta-14 has the fix

fatihict15:09:37

500 members in this channel parrot

upside_down_parrot 44
🚀 28
fulcro 36
aw_yeah 12
4
hoynk19:09:03

Is there a place with the API docs for Fulcro 3 (like this one https://cljdoc.org/d/fulcrologic/fulcro/2.8.13/doc/readme).

bbss02:09:08

Oh, right sorry about that. It's that fs/dirty-fields returns dirty fields as I expect (and use to send as diff for back-end :)) but fs/dirty? doesn't say the form is dirty..