I’m quite new here. Just got to tinkering around and wanted to try my hand at pulling in the css-injection and I don’t know if the book is out of whack with what I have to place in the require or what? Presently I have

and I’m getting the following error

So I think either something is off or I’m misunderstanding something.

Are you using "2.6.0-RC8"?

Is :ui/react-key supposed to get changed whenever you save a source code file? Is there anything that needs to be done to make that happen when using shadow-cljs?

@vaedasynapse Use RC9…that is brand new

@cjmurphy Not needed anymore. Is it still in the book? The hot code reload should do a remount, which does a forced root render, which turns off the short-circuits…so it should just work.

The remount should be in your code for reload, though

https://shadow-cljs.github.io/docs/UsersGuide.html#_lifecycle_hooks

you just need to call mount again if you’ve converting to shadow-cljs using lifecycle hooks

Hi, I’m playing around with RC9, shadow-cljs and devcards. I’m noticing that if I say change the body of a stateful component, that ’s referenced in a card. I don’t see the corresponding update in the card without a page refresh. In the console, i see the component, then its it’s card namespace being refreshed, along with the call to ..cards/refresh. Do I need to add something to the (refresh) function?

which kind of card are you using?

@eoliphant

defcard or defcard-fulcro?

the ‘regular’ defcard

then the shouldComponentUpdate will prevent a refresh unless you change props

ah

ok

add a random prop….like :k (rand-int 1000)

and it’ll refresh

ah ok. yeah was just messing around with layout so handn’t even added props

will add that trick

defcard-fulcro force refreshes them automatically, but runs them in a complete app context as well..so if you’re just playing with layout (which I so as well), just use the random prop trick

that did it thanks. Just wanted to say man, this is an amazing piece of work. I actually tried getting into it some months ago and it just wasn’t clicking. Just finished a good sized re-frame project, and kept hitting places where I kept thinking “fulcro does this for you” lol. So have jumped back in, and it’s making a lot more sense

glad to hear it 🙂

I keep trying to figure out how to make it easier to get into.

but I’m also sapped in terms of time 😞

that’s kind of a theme for me with some of this stuff. Started playing with specter last year, and same thing. for more complex cases, it was kind of brain itching.. but then put it aside for a bit, then it made a lot more sense. Yeah the materials are great. I actualy I think kind of messed up. I went straight to the vids and tutorial before. The ‘getting started’ in the docs, is much more manageable to get your feet wet. Yeah I can imagine.. this is a lot of stuff

can someone confirm if this is a valid query? supposed to return some info about all sources required to compile clojure.string

[{[::m/cljs-ns clojure.string]
           [{::m/cljs-sources [::m/resource-info]}]}]

meh indent

[{[::m/cljs-ns clojure.string] [::m/cljs-sources]}]

works fine without the join

not sure if my join is just wrong or I'm just running into a pathom error

I don’t understand the clojure.string bit

[::m/cljs-ns clojure.string] this is an ident basically

you’re using a symbol for an ID?

its quoted. yes

just left out the quote sorry

join to a query with a subjoin…looks ok at first glance

ok I'll ask in #pathom just wanted to confirm if I'm just doing the join wrong 😛

you using connect?

yes

@tony.kay There are quite a few examples of :react-key in code examples in the book (some where it isn't put in attributes to the topmost div). Also in the source doc for style-element it mentions a :react-key - seeing that I started to think it might not be dead after all.

(defn ^:dev/after-load start [] (mount @root-comp))

ok, yeah, someone should clean those up in the book 😜

I’m playing around with the react component wrapper stuff in the incubator. ‘no props’ components don’t seem to be working

...
(:require ["semantic-ui-react" :as sui-react]
....

(def Button (uc/component-factory-simple sui-react/Button))

; in my component
 (sui/Button {} "Hi") ; is fine
 (sui/Button "Hi") ; doesn't render the button content

Ah, sorry I closed your issue. I think you’re right. That helper needs to pass children

no prob, i filed it then remebered we’d just been talking alol

quick question, i’m getting the impression that fulcro tends to engender more of a bottom up approach? was just wondering about the typical development style/pattern

well, I’m not certain this is an issue, per-se. The args lists are clear on simple factory, and do not say that props are optional

I think you want component-factory-localized

well, not really there either

because that one does component localization

you want a 3rd alternative

you want the function component-factory-localized, but with the non-localized helpers

yeah i guess more the ‘default’ behavior, where if there are props they’re used, if not it a child/children

so, the simple one doesn’t allow that

want an easy contribution, copy this function: https://github.com/fulcrologic/fulcro-incubator/blob/develop/src/fulcro/incubator/ui/core.cljs#L13 after importing the regular dom under a diff alias, and use the non-localized stuff the exact same way

ah gotcha

will check it out 😉

If anybody needs an example of hot code reloading in a shadow-cljs project, here is something: https://github.com/chrismurrph/fulcro-react-vis/blob/c467396ab09be2b18587b4ef0fd9090fa23675a9/src/main/general/user.cljs#L26

The fulcro lein template for shadow-cljs should also work

(it uses the shadow config file instead of metadata)