Fork me on GitHub
#fulcro
<
2018-08-19
>
Pontus07:08:25

awesome, I just upgraded fulcro and I no longer see Garden. The (gzipped) file size of the bundle went down with about 15K.

cjmurphy07:08:28

I've written a Fulcro Stack Overflow question, mainly about using @wilkerlucio incubator ReaKit stuff: https://stackoverflow.com/questions/51915545/css-and-reakit-from-fulcro

👏 4
timovanderkamp08:08:59

The query in the component ‘Experiment’ doesnt seem right

timovanderkamp08:08:48

In the component ‘Experiment’, i think it should be a join [{:but-primary (prim/get-query ..)}]

cjmurphy08:08:29

Good pick up. That's not the first time I've made that mistake either.

cjmurphy08:08:00

You fixed the problem 🙂

cjmurphy08:08:15

I'll answer myself in a couple of days if no-one else has, but hopefully you or someone else will jump in...

timovanderkamp09:08:01

I will answer it on stackoverflow

hjrnunes17:08:09

hi all, do root namespaced keywords get special treatment, somehow? I'm trying to figure out why [:root/dropdown '_] doesn't show up under :phone/by-id values in the app-db In this example: http://book.fulcrologic.com/#_selecting_an_entity_for_edit

levitanong18:08:09

@hjrnunes they don’t get special treatment. Links (idents with underscores) are specifically used to return data outside of the component tree

hjrnunes18:08:24

@levitanong thanks. So if I'm seeing this [:ui/dropdown _] [:fulcro.client.primitives/not-found nil] in my component state what might be missing?

levitanong18:08:32

@hjrnunes are you using form-state?

levitanong18:08:49

When does this happen?

hjrnunes18:08:10

I see it from the moment I load my card

hjrnunes18:08:45

It's in the quey for my component

levitanong18:08:43

could be related to an issue i reported 3 days ago: https://github.com/fulcrologic/fulcro/issues/231

hjrnunes19:08:16

well, I put the example on a card in my project, and I don't see those

hjrnunes19:08:31

So must be something I'm (not) doing

hjrnunes20:08:32

@levitanong So I think this must be related to loading the data. In the merge after the load, I'm getting the data tree part of the link query full of not founds. See here https://pasteboard.co/HzWzoZ7.png

hjrnunes21:08:01

so these items are being marked as missing, because they're in the query but the server isn't returning them

hjrnunes21:08:25

But since they're removed from the query sent to the server I don't really get why this is happening

hjrnunes21:08:08

in fact, I have ui/editing? there, that is not marked as missing

hjrnunes21:08:38

shouldn't :ui/dropdown be ignored too since it's not sent to the server?

currentoor21:08:37

@tony.kay in RC8 it looks like the library consumer has to require [fulcro-css.css] somewhere in their clojure code if they want to use defsc and CSS in clojure

currentoor21:08:36

we could probably fix it by adding that require in fulcro.client.primitives in clojure only

currentoor21:08:51

then we’d still get the property of not including garden in the client if it’s not used

currentoor21:08:28

i’ll verify

currentoor21:08:41

by the way I’m loving these changes! simple_smile

currentoor21:08:01

and i never looked into localized dom, that looks great!

wilkerlucio21:08:40

localized dom is pure awesomeness 🙂

Josh Horwitz21:08:25

Is there an article to read to learn what localized Dom is?

wilkerlucio21:08:51

but in a sentense, it expands the css class names to have unique names (by prepending the namespace and class name)

hjrnunes22:08:59

hey guys, any insights on the above? I think I can reformulate my question as: what's the proper way of using link queries for the query of Components that are used in load?