Fork me on GitHub
#fulcro
<
2018-05-16
>
tony.kay03:05:48

2.5.5-SNAPSHOT is on clojars. This is a test release of Wilker’s patch to mutation merges with tempids.

timovanderkamp11:05:20

Anyone else having issues with the shouldComponentUpdate-lifecyclemethod?. It seems like im getting react-props instead of fulcro-props when the lifecycle method is being called. :shouldComponentUpdate (fn [next-props next-state] ..) I looked into the default implementation of this lifecycle method in fulcro.client.primitives and was able to retrieve the props in the same way: (.-props (gobj/get next-props "fulcro$value"))

timovanderkamp11:05:22

Also noticed that there is no reshape-fn for this lifecycle method, might this be the problem? https://github.com/fulcrologic/fulcro/blob/develop/src/main/fulcro/client/primitives.cljc#L252

tony.kay04:05:06

The only thing I've ever wanted to override that for is to set it to false for turning off subcomponent rendering for things like d3. I did not notice the props we're right. The code for it should be identical to that from Om Next, since that's where it came from originally.

tony.kay04:05:13

The built-in behavior is able to short-circuit if the props have not changed...so there should really rarely be a reason to override it. It should, of course, be fixed if it is broken, but in 3 years I've not seen anyone say anything, which sorta indicates no one is overriding it

tony.kay04:05:40

yeah, the missing reshape is why you're seeing react low-level stuff...that should be fixed.

tony.kay04:05:14

Fixed on develop...not yet pushed to clojars though

🎉 4
timovanderkamp05:05:56

Great, thats why I was doubting if I was doing something wrong, how could no one have ran into this issue. I did find this though: https://github.com/omcljs/om/issues/816. Someone did ran into it in 2016

tony.kay01:05:51

funny, and he closed it thinking it was “his problem” 🙂 So, Om Next still has the issue

myguidingstar18:05:47

hi everyone, I've been working on a full-stack implementation of the famous Realworld app with fulcro on the frontend and Duct+Walkable+Postgresql on the backend

myguidingstar18:05:47

Would be great if anyone can pitch in 🙂

myguidingstar18:05:06

The experience with Fulcro so far is superior. Many thanks to Tony Kay and Wilker Lucio for your hard work

🎉 20
🙂 4