@tony.kay question, I'm using the mutation query feature, but one thing is tricking me, I set the component to be used on the return, but I have situations of success and failure (mutation might fail by bad data, internal network error, etc...), the success case works very fine, but on the error case it seems like the integrate ident is failing

when there is the error, I don't have the ident value (it gets nil, because the response map contains only the error), that ident with nil value is correctly added to the database

but the reference is not placed where it should be

so, the failed ref looks like [:some-return-ident nil], but it's assigned as just nil on the target

is this behaviour expected?

The expectation is exactly what the demo shows in the book.

I don’t remember what’s there, to be honest

I'm just trying to clarify before I jump in on debug, just hoping you might have an idea solution 🙂

returning hooks up a merge for that shape of data. If something causes you to not get that data, then there isn’t much to merge 🙂

the query of my component contains the error fields in question

and this is been correctly read and assigned to DB

but it has to contain the ID, or it cannot normalize

just the ref is not

can't it just normalize as [:bla nil]?

I don't understand why the nil is not a valid thing here

it is everywhere else

oh, you’re saying that the integration of the ident is failing, but the normalization is otherwise fine?

yeah

not sure why that would be

can be a bug, just trying to clarify if there is a reasoning behind it

Has anybody else gotten this warning when they run the lein template generated project with shadow-cljs?

------ WARNING #1 --------------------------------------------------------------
 File: fulcro/client/dom.cljs:66:1
--------------------------------------------------------------------------------
  63 |               (real-factory p)))
  64 |           (apply real-factory props children))))))
  65 | 
  66 | (dom/gen-react-dom-fns)
-------^------------------------------------------------------------------------
 Use of undeclared Var fulcro.util/force-children
--------------------------------------------------------------------------------
  67 | 
  68 | (defn render
  69 |   "Equivalent to React.render"
  70 |   [component el]
--------------------------------------------------------------------------------

It only seems to happen the first time you run npx shadow-cljs watch main cards test.

Circular dependency detected fulcro_css.core -> fulcro.client.primitives -> fulcro_css.css -> fulcro.client.primitives

This is with "2.5.0-alpha4", back to alpha1 inclusive.

@cjmurphy I had this when I accidentatlly included fulcro-css somewhere

Thanks @mitchelkuijpers I don't have that. In fact just putting Fulcro into this project for the first time. Only thing I can think of that may be dragging in Fulcro CSS is Fulcro Inspect. (And only a slight chance there as tools normally don't dictate dependencies - mark everything as provided - and when I last looked that was pretty much the case with Fulcro Inspect - hmm - but maybe it needs/likes to use the latest CSS stuff when the tool pops up, no matter what old Fulcro CSS you are using).

@cjmurphy fulcro-inspect definately dragges it in.. are you using leiningen?

Yes using lein.

if you add this to your defproject

:exclusions [fulcrologic/fulcro-css]

this will exlude it everywhere

Does doing that have a cost? I want to be using the latest css stuff.

No it doesn't because it has been added to fulcro

It has been added since 2.4.0: IMPORTANT CHANGE: Integrated Fulcro CSS. You should remove fulcrologic/fulcro-css from your dependencies, and exclude it from any libraries that bring it in.

from: https://github.com/fulcrologic/fulcro/blob/develop/CHANGELOG.md

Right, so excludes where it is used a dependency by other libraries.

Yes it will just add the exclude to every dep because you never want to drag in fulcro-css

Thanks @mitchelkuijpers Nice trick to know about, and I'm now past those circular deps errors.

Nice!

I thought lein new fulcro myapp made a new fulcro project with phantom-clj

@cjmurphy @mitchelkuijpers the yesterday release of fulcro-inspect bumped fulcro and removed the fulcro-css dep, so you can just bump that and it should work

Using fulcro.client.alpha.dom, what is the recommended way to put two or more classes on a div? Something like (dom/div :.red :.shadowed "I have two classes") generates a clojure.spec error.

@grant you need to "glue" then, as: (dom/div :.red.shadowed "I have tow classes")

Ah, ok, cool. So :.red.shadowed would be equivalent to class="red shadowed"?

And if you want to give something both a class and an id, you just have to put the id in the passed map? (dom/div :.class {:id "my-id"} "content") instead of something like (dom/div :.class :#my-id "content")?

you’d do it like this (dom/div :#id.class "content")

here’s http://book.fulcrologic.com/#AlphaDOM the new api

Is there already some kind of macro to consume React components just like new fulcro.client.alpha.dom? without converting to js, nils, etc?

Ah, cool. @wilkerlucio, @troglotit, thanks for the help.

Version of Fulcro?

if you’re using 2.5+, you don’t need the conversion

just {:type "submit"}

The latest, yes 2.5+

and AFTER the keyword

the keyword for classes must come first

Oh right

spec is: (tag [kw] [props] [children]) (where brackets indicate optional, but order is required)

you never need the #js or clj->js anymore

Yes good, and that works, in that no longer fails spec.

though technically (div nil (p nil "hello")) or (div {} (p {} "hello") may be slightly faster at runtime than (dom (p "hello")) because the latter forces props detection at runtime instead of compile time

Fulcro 2.5.0-beta1 is on clojars. I’ve also updated the lein template to generate correct projects (I hope…did lots of testing).

The Getting Started chapter was split out to a repo, as was the tutorial. Lots of doc changes. PLEASE tell me if you see anything hosed. This is a lot of stuff to update for this change.

website links, etc.

I’m pushing a new version of the book in a moment

New version of Developers Guide is live.

New lein template is live

NOTE: Fulcro itself has moved to Clojure 1.9. If anyone is still using 1.8 and sees an issue, let me know.