Fork me on GitHub
#fulcro
<
2018-02-11
>
mitchelkuijpers12:02:21

We love shadow-cljs too

thheller12:02:24

glad you all like it 🙂

pithyless13:02:30

Is there a way to tell fulcro-inspect to ignore certain keys in the db? I’ve just loaded 8k tags and it’s lagging an otherwise pleasant experience.

pithyless13:02:25

Or maybe to never render more than X items per key?

pithyless14:02:09

So, it’s not a rendering issue, per se, but probably something inspect is doing internally. I’m loading extra data during app initialization, it’s not being rendered anywhere on screen, it’s not being queried by any UI components, and the app is noticeably lagging even if fulcro-inspect is disabled. Only way I’ve been able to fix the lag is to disable fulcro.inspect.preload and app starts running smoothly.

wilkerlucio19:02:25

@pithyless currently not, but shouldn't be hard to implement, this could be part of the setup configuration

wilkerlucio19:02:04

would be intersting to investigate the root cause

wilkerlucio19:02:35

on the make of spec I tried to reduce this as max as we can (like delaying processing of tx diffs to only when you open it)

wilkerlucio19:02:32

but a big db shouldn't hit you hard, can you write a minimum case reproducing?

tony.kay14:02:16

For best operation in the complete Fulcro model you just want something that uses minimal component local state…you want controlled components. If the component renders much outside of real data state, then you lose history features. Now, as long as those things are inconsequential (e.g. animation data), then it’s fine. If the components keep real state (like sort order), then you get more and more disconnected from the abilities of things like the support viewer, since that state is hidden. All that said, at the end of the day any react component will work unaltered with Fulcro…just send them props 🙂

tony.kay14:02:23

Your bigger concern is getting access to the js code. I find that shadow-cljs works better when it comes to using external js libraries.

donmullen16:02:05

Thanks @U7GCXSGBH @U0CKQ19AQ. Integrating react-tools/react-table into fulcro probably more than I want to try at this point.