they do not. I did not port them from Om Next. You’re welcome to do so, though

@tony.kay https://github.com/fulcrologic/fulcro/pull/137, added just some basic, and one covering the new case, if we can just get though, refactoring that function is a much bigger job, I'm in to do that, but not today, trying to get those graphql docs out 🙂

@wilkerlucio Thanks. Did you bring over tests? I don’t really feel very comfortable with db->tree changes that aren’t covered. It was on my todo list to port them, but I figured I would not need them until work was done on that function….and it seems like you’ve gone and done work on that function 🙂

I didn't, just saw they are a bit spread, and don't seem much complete (looking at old om code), would be enough if I just copy over all past tests?

I do seem to remember they were kinda light 😕

perhaps that is why I didn’t bother? Don’t remember.

it’s a very critical function, though

this change should only affect joins with lists on keys, so I guess it should be safe, I can try to run some projects over the change as a sanity check

yes, that is a first required step for sure

Great news @tony.kay we had lot's of trouble getting logback to work with timbre

So, apologies…2.1.7 is on clojars, but I accidentally released a change I did not mean to release yet. I refactored the logging to remove dependencies, but that change may cause problems with existing code…I have not reviewed it. I’d recommend staying with 2.1.6 for the moment. I’ll probably do a follow-up release of 2.1.8 that will revert those changes for now.

Version 2.1.8 released. Includes the history bug fixes, but not the logging changes.

@mitchelkuijpers and @pithyless if you wanted to try 2.1.7 and give me feedback it would be helpful/welcome…the work is done for changing logging, but I had not intended to release it until it was better tested against a number of things.

@wilkerlucio fyi, here is the source code for walkable SQL. Duct framework is not required, it's just for development

https://bitbucket.org/myguidingstar/walkable

cool 🙂

atm I need to spend some time with my father. He needs help

sorry for the delay

on thing I would like to point out about the examples, check this thread: https://github.com/fulcrologic/fulcro/pull/137

no worries at all, take care of your family, no one is rushing 😉

thanks

Initial version of Bulma library for Fulcro (work in progress, later) -- http://www.photonsphere.org/posts-output/2018-02-07-fulcro-bulma/