Fork me on GitHub
#figwheel
<
2020-05-14
>
reefersleep11:05:50

@bhauman yes, it’s a part of the :plugins vector.

bhauman12:05:07

so you will want to set :figwheel {:readline false …} in the project.clj

reefersleep12:05:13

That’d be fine in my own personal project, but if I do it globally in this project, I’ll break readline functionality for those of my colleagues who use it.

reefersleep12:05:37

Is it possible to put into a profile that can be +’d at startup?

reefersleep12:05:44

But it’d have to be merged with the options from the other profile(s).

reefersleep13:05:07

So something like :no-readline {:figwheel {:readline ^:replace false

bhauman13:05:52

that could work you may also need to remove the rebel-readline library in the profile as well

reefersleep13:05:27

How do I instruct start-figwheel! to merge profiles?

bhauman13:05:41

oh it doesn’t

bhauman13:05:06

you can supply options to start figwheel

reefersleep13:05:38

Currently I’m pointing towards my build profile, like (ra/start-figwheel! "my-profile")

reefersleep13:05:05

Is it an either/or thing? Either I supply the entire build information on my call, or I refer to exactly 1 profile?

bhauman13:05:59

You can fetch the config and alter it (figwheel-sidecar.config/fetch-config)

reefersleep13:05:08

Cool! I’ll try that.

bhauman13:05:29

(start-figwheel! (figwheel-sidecar.config/fetch-config) "dev")

reefersleep13:05:42

@bhauman that worked great for merging the :figwheel options. However, the dependency is mentioned in our project.clj like

:profiles {:dev {:dependencies [[figwheel-sidecar "0.5.19"
                                 :exclusions [org.clojure/clojurescript
                                              org.clojure/core.async]]
                                [com.bhauman/rebel-readline "0.1.4"]
...

reefersleep13:05:49

And that does not seem to be available from the config.

bhauman13:05:46

is it working that way?

bhauman13:05:00

without getting rid if rebel-readline

reefersleep13:05:34

The REPL is running, and the config ends up having the :readline false set in :figwheel for the desired build

reefersleep13:05:40

but it does not get rid of rebel-readline

bhauman13:05:51

so you still have the warning

bhauman13:05:31

well that seems like a bug

reefersleep13:05:48

Maybe it’s just not possible with the way our :profiles is set up?

bhauman13:05:48

the readline false option should be respected

reefersleep13:05:05

Thought you said I might need to remove the dep as well.

bhauman13:05:28

yeah if you want it to work right now you do

reefersleep13:05:08

Just for fun, I’ll try testing it without the dep

reefersleep13:05:46

Right, I’m not prompted when the dependency is not present. Verified 🙂

reefersleep13:05:20

Should I file this properly at the lein-figwheel github repo?

bhauman13:05:43

no worries I’m going to look at it in a moment

reefersleep13:05:30

Thanks for figwheel, btw, it’s great! I think it’s part of the reason I got so into CLJS to begin with.

👍 4
bhauman13:05:29

awesome, BTW the I’ve got the new :bundle target working in lein-figwheel and in figwheel-main

bhauman13:05:02

so if you want to try npm integration its pretty sweet now

👌 4