Fork me on GitHub
#figwheel-main
<
2021-04-08
>
Sigve09:04:22

Are reader conditionals (`#?`) not possible to use with figwheel ? I'm getting:

[Figwheel:WARNING] Could not Compile   src/parser/core.cljs   line:477  column:5

  Conditional read not allowed


  475  (defn ^:export parse
  476    [string]
  477    #?(:cljs (clj->js (-parse string))
           ^---
  478       :clj  (-parse string)))


[Figwheel:SEVERE] java.lang.RuntimeException: Conditional read not allowed

henryw37409:04:13

they are allowed. file extension should be .cljc

Sigve09:04:37

Thanks! I just went through the https://clojure.org/guides/reader_conditionals page, but read cljc as cljs

bhauman20:04:29

@tkjone I’m working on fixes for all the logging problems in 1.10.844

👍 5
🙏 1
athomasoriginal20:04:56

Excellent! Glad I didn’t start a PR 😅

athomasoriginal20:04:43

Let me know if you need help testing anything!!

bhauman23:04:14

@tkjone Just deployed the fixes to 0.2.13-SNAPSHOT

bhauman23:04:29

let me know if its working for you

athomasoriginal23:04:30

@bhauman Tested on a new app (will try on a larger existing one a bit later). I see many warnings in the terminal have successfully been resolved and the browser console warning is also resolved. The remaining warnings thrown (3 total) • target/public/cljs-out/dev/figwheel/main/css_reload.cljc - lines 32, 141 and 144 Example:

bhauman23:04:48

oh cool, good to know

bhauman23:04:18

I’ll fix that up

👍 1
athomasoriginal23:04:54

Tested the HMR and Live Refresh and these are working and the project is configured using autobundle + webpack