Fork me on GitHub
#figwheel-main
<
2020-06-16
>
folcon17:06:27

Anyone else using re-frame-10x with the new webpack? If you use :exclusions [cljsjs/react-highlight] so that :npm-deps true works it doesn’t take that well… It seems to work without using the exclusions, but I’m not 100% certain that’s a good thing…

bhauman18:06:28

@folcon I just wrote this up

bhauman18:06:59

I added a :clean-outputs Figwheel option and a --clean CLI opt to the 0.2.9 release of figwheel.main

bhauman18:06:14

this is more than likely what you are running into again

bhauman18:06:23

this may not solve your problem with re-frame-10x as it depends on how they refer to the react-highlight library

bhauman18:06:55

yep that’s a problem the global-export name is react-highlight.js and not react-highlight

folcon18:06:43

Ok, not sure if that’s something they’ll want to change?

folcon18:06:50

Reading your docs =)…

bhauman18:06:28

yeah my doc’s have little to do with this problem, but they are the result of the problems you had when you tried to get advanced compile working

folcon18:06:03

Thanks for the heads up! Yea, that bit of fun ;)…

bhauman18:06:20

@juhoteperi ^ refering to above shouldn’t react-highlight also be exported as react-highlight so that npm dependency resolution works correctly?

juhoteperi21:06:45

The npm name is react-highlight.js so the package should be correct