Fork me on GitHub
#figwheel-main
<
2018-12-04
>
bhauman11:12:07

I’ll fix that now

bhauman11:12:39

@dominicm @pesterhazy fixed. I’ve deployed a new snapshot, I was on a dev branch when I deployed the last one

dominicm11:12:38

@bhauman anything concern you about the event-target being nil? Or should I just switch to using the snapshots and those are pretty stable?

bhauman12:12:52

@dominicm not sure what you are referring to

bhauman12:12:56

Are you using node?

bhauman12:12:12

@dominicm that was another bug, dang

bhauman12:12:34

Thanks for pointing it out

bhauman12:12:30

no actually it shouldn’t be null

dominicm12:12:55

@bhauman I'm in the browser.

dominicm12:12:41

@bhauman I'm a little confused really, happy to get debugging at a low level with a little direction

bhauman12:12:13

@dominicm there is a problem here and I just fixed it, but it should fall back to goog.events.EventTarget, so its like that’s not loading in the correct order for you

bhauman12:12:38

which is a different problem

bhauman12:12:50

that false shouldn’t be there so I’m pushing that fix now

orestis12:12:51

I recently ran into an issue where loading the CLJS stuff in head resulted in complaints because figwheel was trying to add an event listener to document.body which obviously didn’t exist at that time. I see that some recent version of figwheel-core fixed that, by adding that listener to document instead, and I’m bringing that custom version in manually for now 🙂

bhauman12:12:51

I’d use 0.2.0-SNAPSHOT after I deploy a fix for that

orestis12:12:56

Oh wow you are talking about the exact same thing 🙂

orestis12:12:15

I need to add a PR to re-frame-10x because they have a similar issue.

orestis12:12:58

(I’m integrating CLJS/figwheel into a hairy old jquery/require.js app and the only way to do it is to load the CLJS stuff first thing in the head, otherwise jquery & co take over my scripts! What a mess)

orestis13:12:19

Yeah, it kinda works so far 🙂

bhauman13:12:37

@dominicm 0.2.0 is very stable. I should deploy it this weekend.

bhauman13:12:11

unfortunately I don’t have any new bells and whistles in it to justify the 0.2.0 label 🙂

bhauman13:12:58

@dominicm new snapshot deployed with fix for event-target

dominicm13:12:21

@bhauman 0.2.0 already worked with the same code. I'll switch to the snapshot then 😊

euccastro23:12:44

I'm trying to port a project that was using lein-figwheel to figwheel-main. as a start I just removed all figwheel configuration and added the figwheel-main dependency in the :dev profile. when trying to run lein run -m figwheel.main I get the following error: java.io.FileNotFoundException: Could not locate figwheel_sidecar/repl_api__init.class or figwheel_sidecar/repl_api.clj on classpath. Please check that namespaces with dashes use underscores in the Clojure file name.

euccastro23:12:16

adding a dependency on figwheel-sidecar fixes it, but I don't see that in the figwheel-main docs so I don't know if it's the right thing to do

euccastro23:12:13

sorry, PEBKAC. I had missed that this project had a dev/user.clj that was requiring figwheel-sidecar explicitly. removing that fixed it.