OK now I'm looking into the Cannot find module '@cljs-oss/module-deps' problem that crops up when you add or remove dependencies while using global-exports

This also seems to lead to a race which prevents the global-export from binding to its munged name.

@bhauman How does it happen that the (enable-console-print!) is no longer needed to print to the console using println?

the only way to get output to the REPL is to hook the *print-fn*

in cljs

figwheel has to do this in order to print output to the repl

figwheel provides https://figwheel.org/config-options#client-print-to to determine where you want prints to go to

enable-console-print! is a blunt instrument which obliterates these hooks

Well my question is slightly different. I remembered from official Clojurescript articles that enable-console-print is needed to enable printing to the js console using println. Now with the newest clojure after successful compilation I can still println to the console without enable-console-print!. That's nice! But question is why?

I thought it's obligatory to have it

OK its because figwheel has to make prints go to the REPL, so it has to change the *print-fn* and if it has to change the *print-fn* it might as well make prints go to the console as well because we are in development mode when we use figwheel.

figwheel has to alter how print works

if you want prints to go to the REPL

Well sorry I was not accurate. I compiled the program with the cljsbuild. When I run the compiled program with node then the prints go to the console even if the enable-console-print! is not used. How does it happens? I remember that in the past it was not possible

OK that's not a figwheel thing, so I'm not sure

; (

I will try my luck on #clojurescript

mfikes [3:23 PM]
@Karol Wójcik It was 1.10.238 (`*print-fn*` automatically set):  (edited)

big improvements to global-exports usage in 0.1.8-SNAPSHOT

Was just experimenting with figwheel-main. Haven't gotten a chance to condense for minimal reproduction yet, but just a heads up.... Was getting "[Figwheel] Compile Exception: Don't know how to write JSON of class java.io.File" errors when Figwheel reloaded after cljs change. Didn't find any additional info in the logs. Added clojure.pprint/pprint (Throwable->map e)) at https://github.com/bhauman/figwheel-main/blob/3fbeb0c/src/figwheel/main.cljc#L91 to see full stack trace. Cause was at https://github.com/bhauman/figwheel-core/blob/77bf8be/src/figwheel/core.cljc#L670 . The warning-infos contain a Java.io.File instance. So I think it will bomb attempting to reload whenever there are compiler warnings (which of course should be resolved anyway). e.g.

({:warning-type :single-segment-namespace,
     :line 1,
     :column 1,
     :ns cljs.user,
     :extra {:name dev},
     :message "dev is a single segment namespace",
     :file #object[java.io.File 0x3aa869be "devsrc/dev.cljs"],
     :file-excerpt
     {:start-line 1,
      :excerpt

this is good feedback, would love to know how this is happening.

basically when you allow load-warninged-code?

@lmarks ^

Hadn't explicitly specified a value for that.

Was calling figwheel.main.api/start in a script:

(apply figwheel.main.api/start (concat [{:open-url false
                                               :watch-dirs ["src" "devsrc"]
                                               ;:css-dirs ["../app/assets/stylesheets" "resources/public/admin/css"]
                                               :css-dirs []
                                               :target-dir "resources"
                                               :log-file "figwheel-main.log"
                                               :log-level :debug
                                               :mode :serve}]
                                       configs)))))

I'm getting the same error whether I explicitly set :load-warninged-code to true or false

is :http-server-root a thing still?

if not what replaces it?

My :single-segment-namespace was one of my :preloads. Taking it out of :preloads still gave the same "Don't know how to write JSON of class java.io.File" error in the browser, but in that case, it's pretty obvious because the compile warning is in the log output. Everything works as expected if I resolve the warning.

@lmarks so you had a single-segment-namespace named "dev"?

I can use that to test things

@dnolen https://figwheel.org/config-options#ring-stack-options

it's nowhere near as straight forward as :http-server-root but much more configurable

yeah I have to document this particual case

{:static {:resources "public"}}

supposedly :ring-stack-options {:static {:resources "public"}} will do the job

@bhauman Generated a minimal app from clj -A:new figwheel-main figwheel-main.app --reagent and added a commit to reproduce.

https://github.com/lenny/figwheel-main.app/commit/87f69c09e802235d8b7911da017109214db8e0b3

@lmarks thanks!!

@lmarks fixed https://github.com/bhauman/figwheel-core/commit/c4f77a6ad75affbd35435fc0a2e6179bfeaa74cd