etaoin

lread 2022-05-10T16:02:35.181369Z

@igrishaev I have a dev question about testing etaoin 🧵

lread 2022-05-10T16:02:56.040279Z

before embarking on new work, I like to make sure all tests pass

lread 2022-05-10T16:04:14.033519Z

I see that for etaoin you have automated tests running on CircleCI under Linux, but am wondering what your expectations are for tests successfully running on macOS and Windows.

lread 2022-05-10T16:04:48.705469Z

I just attempted a test run on my macOS dev box and did get a failure.

lread 2022-05-10T16:05:58.550559Z

I think that CircleCI now allows macOS and Windows in their free tier. If I’m right about that, would it be interesting to add automated tests for those platforms too?

igrishaev 2022-05-10T16:06:10.427749Z

well, tests for Etaoin have always been pain in the ass.

1
igrishaev 2022-05-10T16:06:46.128609Z

yep, running the tests on all the three platforms would be great

lread 2022-05-10T16:07:13.091569Z

What is the pain? Setup or flakiness or both?

igrishaev 2022-05-10T16:07:52.131359Z

well, to setup all the drivers (wget them, install, etc...) then pass the tests

lread 2022-05-10T16:08:35.955939Z

Ok, I’ll create a new git issue and attempt a PR, if that works for you.

igrishaev 2022-05-10T16:08:47.273029Z

Maybe it worth preparing a docker image with all the stuff installed and push it into the public repo

igrishaev 2022-05-10T16:09:27.693919Z

yes, please. I work quite rarely on Etaoin as I'm far from the browser tests nowadays

lread 2022-05-10T16:10:10.656129Z

Cool, thanks so much for the chat!

lread 2022-05-10T16:41:57.875549Z

Note: https://support.apple.com/en-us/HT204416. > Apple no longer offers Safari updates for Windows. Safari 5.1.7 for Windows was the last version made for Windows, and it is now outdated. I expect you are ok with no longer testing Safari on Windows?

lread 2022-05-10T21:43:27.036109Z

I’ve started getting http status 400 returns for webdriver DELETE calls (session, cookie, window) when using safaridriver on macOS. Which I find odd. Does that ring any bells for anybody?

safaridriver --version
Included with Safari 15.4 (15613.1.17.1.13)

lread 2022-05-10T21:46:39.908959Z

When running etaoin tests:

ETAOIN_TEST_DRIVERS='[:safari]' lein test :only etaoin.api-test

lread 2022-05-16T05:01:07.101909Z

FYI, this is now fixed on master

lread 2022-05-10T22:24:00.170919Z

Next question: https://github.com/ariya/phantomjs/issues/15344, is anyone still using it? Does etaoin need to support/test against it anymore?

lread 2022-05-16T05:00:28.423819Z

FYI, I dropped testing on PhantomJS