etaoin 2022-05-10 | Slack Archive

@igrishaev I have a dev question about testing etaoin 🧵

before embarking on new work, I like to make sure all tests pass

I see that for etaoin you have automated tests running on CircleCI under Linux, but am wondering what your expectations are for tests successfully running on macOS and Windows.

lread16:05:48

I just attempted a test run on my macOS dev box and did get a failure.

lread16:05:58

I think that CircleCI now allows macOS and Windows in their free tier. If I’m right about that, would it be interesting to add automated tests for those platforms too?

igrishaev16:05:10

well, tests for Etaoin have always been pain in the ass.

igrishaev16:05:46

yep, running the tests on all the three platforms would be great

lread16:05:13

What is the pain? Setup or flakiness or both?

igrishaev16:05:52

well, to setup all the drivers (wget them, install, etc...) then pass the tests

lread16:05:35

Ok, I’ll create a new git issue and attempt a PR, if that works for you.

igrishaev16:05:47

Maybe it worth preparing a docker image with all the stuff installed and push it into the public repo

igrishaev16:05:27

yes, please. I work quite rarely on Etaoin as I'm far from the browser tests nowadays

lread16:05:10

Cool, thanks so much for the chat!

lread16:05:57

Note: https://support.apple.com/en-us/HT204416. > Apple no longer offers Safari updates for Windows. Safari 5.1.7 for Windows was the last version made for Windows, and it is now outdated. I expect you are ok with no longer testing Safari on Windows?

lread21:05:27

I’ve started getting http status 400 returns for webdriver DELETE calls (session, cookie, window) when using safaridriver on macOS. Which I find odd. Does that ring any bells for anybody?

safaridriver --version
Included with Safari 15.4 (15613.1.17.1.13)

lread21:05:39

When running etaoin tests:

ETAOIN_TEST_DRIVERS='[:safari]' lein test :only etaoin.api-test

lread05:05:07

FYI, this is now fixed on master

lread22:05:00

Next question: https://github.com/ariya/phantomjs/issues/15344, is anyone still using it? Does etaoin need to support/test against it anymore?

lread05:05:28

FYI, I dropped testing on PhantomJS

2022-05-10

Channels