eastwood 2022-06-15

This message was deleted.

What is alng aliased to? What ns/library is that from?

Whatever alng/http expands to (it's a macro) has the construct that Eastwood is complaining about.

alng is aliesed to afw.apilang. The thing is that I use the same construct on other places and eastwood doesnt complain there

Right, but it's a macro and it's going to expand to different things in different contexts. So this is a context where that macro expands to, essentially, a degenerate condition.

Without seeing the source of that macro, it's hard to say what specifically is going on...

I think it's the :parse expression -- ~(:parse desc) is going to cause that expression to be evaluated by the macro, yielding nil if you pass a literal hash map that doesn't contain :parse -- also, why is the alt in that or evaluated?

In addition, you are potentially evaluating desc multiple times -- it would be better to bind it once to a local symbol and then use that instead.

Assuming this is your macro and you can change it?

I'm not entirely sure I see why this is a macro at all -- I think it could be a regular function?

Ah, because you want :request in desc to be a symbolic expression and for it to be walked and have functions resolved in a different context?

yup for the last one, and parse is a required part of the so called apidesc, I just missed it since its getting late

the issue is resolved thank you soo much

Might be worth adding an assert into the macro so you can't forget :parse

🙌 1

set the channel topic: Discussion around the Eastwood linter. â„šī¸ support requests are best posted as github issues - thanks for your help!