Clojurians Log v2

Is it possible that module.web’s log-error does not log the exception when using clojure.tools.logging? clojure.tools.logging needs exception as first argument to be properly handled (e.g., the Sentry logback appender processing the stracktrace properly to be shown in Sentry) module.web has this handler:

(defn- log-error [logger ex] 
  (logger/log logger :error ::handler-error ex))

(defrecord ClojureLogger []
  logger/Logger
  (-log [_ level ns _ _ _ event data]
    (let [level  (if (= level :report) :info level)
          logger (impl/get-logger log/*logger-factory* ns)]
      (cond
        (instance? Throwable event)
        (log/log* logger level event nil)
        (instance? Throwable data)
        (log/log* logger level data (pr-str event)) 
        (nil? data)
        (log/log* logger level nil (pr-str event))
        :else
        (log/log* logger level nil (pr-str event data))))))

If this is the case I will create an issue, or do I overlook something?

clojure.tools.logging/log* (note the *) takes a throwable as the third arg, according to its docs: https://clojure.github.io/tools.logging/#clojure.tools.logging/log*, so all seems in order to me

Thanks for that check 🙂 I referred to the arguments of -log

Looks like -log is only called by log-form (https://github.com/duct-framework/logger/blob/master/src/duct/logger.clj#L12), which puts the arguments in the right places. Am I missing something?

Ah log-form great

If that one is called also for other implementation of Logger then it should insert those two arguments

namespace and a delayed random/uuid

(-log [_ level ns _ _ _ event data] is the signature of the ClojureLogger (https://github.com/duct-framework/logger.clojure/blob/master/src/duct/logger/clojure.clj)

log-form has:

this level ns delay event data

ClojureLogger has: this level ns _ _ _ event data

So there seems to be a mismatch in argument count if log-form is used

Ah you are right

I missed the file and line

Okay this means that it fits like this;

@jmayaalv has left the channel

log-form:

this level ns file line delay event data

_    level ns _    _    _     event data

@jivagoalves has joined the channel