Fork me on GitHub
#duct
<
2019-12-20
>
Kevin08:12:19

@weavejester If you have time, could you take a look at these? https://github.com/duct-framework/duct/pull/95 https://github.com/duct-framework/duct/pull/105 It would probably help new people start with Duct 🙂 Also a small README fix: https://github.com/duct-framework/migrator.ragtime/pull/11 Sorry to be linking PRs to you, it’s probably annoying. One of them has been open for quite a while though.

Kevin08:12:02

Also; I added a link to the Duct guide here: https://github.com/duct-framework/duct/wiki I don’t think the guide is referenced anywhere else. But it’s a good source to read.

weavejester14:12:56

@kevin.van.rooijen Linking PRs is fine. I have a lot of repos, so sometimes I can’t deal with everything immediately, and old PRs get lost in the depths of my todo list. I’ve added some comments to the PRs. When they’re resolved, I’ll merge.

Kevin14:12:30

@weavejester Fixed the two comments, I’ll do my best to follow the guidelines from now on. Is the 3rd PR fine?

Kevin14:12:41

Great! Thanks for taking the time to look at them. There’s also a bug in the Duct template for the test profile. I’ll see if I can push a fix tonight / tomorrow.