Fork me on GitHub
#dirac
<
2020-01-12
>
p-himik11:01:46

Just got an interesting log message:

[2020-01-12 13:45:31.565 - INFO] filename violation for ns dirac.playground, got: dirac/playground-template/src/dirac/playground.cljs expected: dirac/playground.cljs (or .cljc)
Not sure what outputs it.

p-himik11:01:24

And I'm not sure how playground-template ends up in the jar.

p-himik11:01:36

Diract 1.5.2.

darwin14:01:15

this looks like a message from cljs compiler - it found playground.cljs on classpath before it looked on disk, my intention was to extract playground-template from jar to disk and then compile it from on-disk files

darwin14:01:59

I wonder why I’m not seeing that message when I run dirac

darwin14:01:14

just googled a bit and it looks like the message is produced by shadow-cljs: https://github.com/thheller/shadow-cljs/blob/master/src/main/shadow/build/classpath.clj#L696

darwin15:01:16

now it makes sense, shadow-cljs indexes all cljs resources and because you have a dep on dirac and dirac has this template directory in its jar, shadow-cljs reports this problem

p-himik18:01:19

Just checked - seems like it worked indeed!

👍 4
p-himik17:01:51

Nice, thanks! I'll try it out when it's released. BTW do you plan to add deps.edn so that Dirac could be used directly from Git by tools.deps?

darwin17:01:25

it should work, but it is not officially supported, the deps could outdated

darwin17:01:20

I’m considering breaking dirac.jar into multiple jars with less deps, e.g. dirac-runtime, dirac-nrepl and dirac-cli

darwin17:01:46

this way we would avoid future clashes, because dirac-cli would not pollute user’s project which is including dirac-runtime

darwin17:01:08

by pollute I mean bringing in heavy deps

p-himik17:01:57

Oh, sorry - I must be blind, I didn't notice the file was there the first time I looked. Splitting into multiple jars sounds nice!

darwin17:01:38

btw. you can do env DIRAC_CLI_VERSION=master dirac, this will use master version

darwin17:01:00

but only for cli tool, this won’t affect deps in your project

darwin17:01:28

when launched that way, it uses that deps.edn AFAIK