Fork me on GitHub
#dirac
<
2017-06-23
>
darwin21:06:57

@richiardiandrea cool, but doesn’t really work for me on my mac

richiardiandrea21:06:15

oh cool that you tested 😄 I was going to ask some colleague here

richiardiandrea21:06:48

mktemp seems different, will debug it

darwin21:06:11

btw. naked path args to mkdir are dangerous, imagine spaces in the filename: https://github.com/elasticpath/rest-resource-viz/blob/dirac-script/scripts/dirac.sh#L55

richiardiandrea21:06:30

yeah I know, it slipped, tnx

richiardiandrea21:06:39

does mktemp -d dirac.XXXXXXX works for you?

richiardiandrea21:06:39

also, do you think it is something I can contribute somewhere? Maybe the wiki?

darwin21:06:44

--directory flag was invalid

richiardiandrea21:06:42

ok works fine here too

richiardiandrea21:06:55

refresh the page to see it anew 😄

darwin21:06:10

but I’m afraid that the script will be quite fragile, so at some point it will break and I won’t know about it / or are you going to maintain it?

richiardiandrea21:06:14

ah ah yeah I think I am going to maintain it in that repo, haven't thought about that part yet

darwin21:06:26

btw. still does not work, btw $OSTYPE is not a thing on mac https://gist.github.com/darwin/ddabaa0e7cb93af73fc78dd9cb496c0c

richiardiandrea21:06:55

maaan, that SO post was lying then

darwin21:06:20

at least it is not defined on my machine

darwin21:06:21

uname is the way to go

richiardiandrea21:06:36

yep I am reading

richiardiandrea21:06:35

do they have x86 versions for linux? I have seen on x86_64

darwin21:06:03

don’t remember

richiardiandrea21:06:05

lol I was wondering, what if you release one they and there have been more than 100 builds ? you'll miss it...and now then I understand why you release so frequently 😄

darwin21:06:40

that’s not the reason 🙂

darwin21:06:04

that 100 number means “scan for last 100 versions to find last valid build”

richiardiandrea21:06:07

ah ah I am joking

darwin21:06:21

chrome devs would have to break 100+ versions so there would be no binaries for them

richiardiandrea21:06:33

I had to increase to 150 for Mac now

darwin21:06:01

hmm, this seems unlikely

darwin21:06:53

btw. the reason I release quite often is that I want to be merging official changes in smaller chunks and I don’t want to fall too far behind canary builds with dirac

richiardiandrea21:06:35

very weird the ''

richiardiandrea21:06:44

returns 478483 but Mac position is 478480

darwin22:06:48

I’m sorry, cannot help, I wrote those scripts many months ago

darwin22:06:59

ah, now when I think about it

darwin22:06:14

different platforms have different positions for official “build numbers”

darwin22:06:22

or rather “might have”

richiardiandrea22:06:25

no problem, you've helped a lot already...probably...yeah...it seems like 😄

darwin22:06:02

imagine chrome build breaking on linux and passing on mac, the mac one will be tagged and released, but linux one will be delayed a few positions until it starts passing again

richiardiandrea22:06:44

yeah now I need a way to detect that...but thanks for the heads-up

darwin22:06:41

you don’t, you know which platform the user is on, so you scan for valid position on given platform

richiardiandrea23:06:32

I ended up fetching links for Dirac's release notes

darwin23:06:00

I think this will be most robust solution

richiardiandrea23:06:47

yeah and parsing a json is more difficult if you want to be cross platform so...will test it on Mac too

richiardiandrea23:06:20

my colleague just went away for a Friday company beer lol 😄

darwin23:06:00

I have to go as well, it is 1am here 🙂

richiardiandrea23:06:08

thanks for your help as usual

darwin23:06:38

np, thanks for caring about dirac’s usability 🙂