Fork me on GitHub
#dirac
<
2017-01-25
>
danielcompton19:01:30

@darwin the new Dirac 1.1.0 requires Clojure 1.9 via a transitive dependency on cljs-oops. Would you consider making it an optional change? We're not ready to move to 1.9 just yet

darwin19:01:45

ah, didn’t know that

darwin19:01:45

that “provided" should mean that your project has last word

darwin19:01:54

I cannot really remove dependency on spec from cljs-oops, so your only option is to include back-ported version for Clojure 1.8, as described here: https://github.com/binaryage/cljs-oops#integrate-with-your-project

darwin19:01:55

you should be able to normally depend on clojure 1.8 and add clojure-future-spec as another dependency and it should work: https://github.com/binaryage/cljs-oops-sample/blob/master/project.clj#L7

danielcompton19:01:16

clojure-future-spec doesn't have CLJS sources

danielcompton19:01:00

Sorry, I wasn't very clear, cljs-oops uses spec, so it forces a dependency, rather than requiring it

darwin19:01:45

are you using latest clojurescript? it includes cljs version of spec

darwin19:01:57

it should be independent on clojure version, AFAIK

danielcompton19:01:35

We're on "1.9.89", will check if we can upgrade

richiardiandrea19:01:02

(which is unfortunate, but hopefully can be solved soon)

darwin19:01:43

explicit clojure 1.8, latest clojure-future-spec and clojurescript 1.9.293 in your top-level project should be enough for cljs-oops to work

darwin19:01:09

unfortunately I rely on spec in oops code and I’m not going to write another version without spec

darwin19:01:30

but maybe dirac runtime might not use cljs-oops

darwin19:01:47

yeah, I could definitely drop the dependency on cljs-oops in dirac.runtime

richiardiandrea19:01:57

btw cljs-oops is really worth having, I am so thankful for it, I am hacking on a d3 project and I would be lost without it

darwin19:01:55

@danielcompton I could release a new version of Dirac in a hour or two, with that dependency removed

danielcompton19:01:18

which dependency?

darwin19:01:28

dirac.runtime -> cljs-oops

darwin19:01:57

it turns out I only need oget and I can re-implement it

darwin19:01:02

in dirac.runtime

danielcompton19:01:22

that would be cool

danielcompton19:01:26

if it's not too much trouble?

darwin20:01:35

@danielcompton v1.1.1 is on clojars, it will take ~15mins for chrome extension store to publish matching extension

darwin20:01:00

but those two will work together: 1.1.0 extension and 1.1.1 runtime

danielcompton21:01:19

Awesome, thanks heaps!