Fork me on GitHub
#dirac
<
2016-06-14
>
darwin00:06:33

I think there is no need to support switchable impls

darwin00:06:02

the problem is that http-kit is used in other parts I think, so I don’t want to have jetty somewhere and http-kit elsewhere

darwin00:06:32

I’d like to pick just one lib, also depends on how the code will look, I will be probably the one who will be stuck maintaining it for foreseeable future

darwin00:06:57

let me think about it, will tell you tomorrow

darwin00:06:13

it is too late here, don’t want to promise anything at this point

superstructor00:06:25

all good, thanks 😄 @darwin

superstructor02:06:42

@darwin: Re cljs-devtools 0.7.0 I’ve tested with boot 2.6.0, jupl/boot-cljs-devtools 0.1.0 and Dirac 0.6.0 - all working fine :thumbsup: Just for boot users we need @jupl to do https://github.com/jupl/boot-cljs-devtools/issues/1 so we can get back :sanity-hints 😉

superstructor02:06:21

@darwin: thanks for the blistering pace of development! All these features are making it far nicer to work in ClojureScript.

jupl02:06:22

I’ve been neck deep in JS work the past few weeks. My apologies for not having a chance to get involved. PRs are welcome at least.

superstructor02:06:57

@jupl all good I know how that is 😄 I’ll work on a PR for that this evening, are you able to merge the PRs from arichiardi ? Some of that work is pretty handy.

jupl02:06:31

@superstructor I did. I asked that the commits get squashed. If I have time later in the week or the weekend I’ll add it manually.

superstructor02:06:38

right sorry hopefully @richiardiandrea has time to squash soon 🙂

richiardiandrea02:06:36

Btw does GitHub have merge with squash now? Just curious

superstructor02:06:14

@richiardiandrea: I verified your install-order branch fixes being able to breakpoint on app init functions (i.e. devtools etc is correctly installed before other init fns)

richiardiandrea02:06:13

Great I wanted to check if that patch worked fine thanks for doing that

richiardiandrea02:06:47

So I guess that one can be merged @jupl

jupl03:06:12

@richiardiandrea: Awesome! I’ll need to jump off so I’ll try to take a look tomorrow

darwin14:06:59

@superstructor: I’m using http-kit only in two places dirac.lib.weasel-server and dirac.lib.ws-server, I briefly looked at the ring wrappers around jetty and those apis look very similar to http-kit, so in theory it should not be hard to replace, feel free to go for it, I’m fine ditching http-kit for jetty. You may convert only dirac.lib.ws-server and I will then consider converting weasel-server as well.

richiardiandrea17:06:27

@jupl: do you want me to squash all the commits, even the readme/deps changes?

superstructor21:06:35

@darwin: great, thanks 🙂 will get back to you when I have a pull request ready.