Fork me on GitHub
#depstar
<
2020-12-24
>
dharrigan04:12:39

Thank you @seancorfield will test this morning 🙂

3
dharrigan05:12:21

Yup works - but first had to align the scm tag to the same as the version, then update

dharrigan05:12:45

works grand now 🙂

seancorfield05:12:06

Cool. Yeah, if they're out of sync, it can't do much to sync them back up.

seancorfield05:12:21

When I first implemented :sync-pom true, if you specified :version and had an existing pom.xml, the call into t.d.a would update the <version> field and then my own sync'ing code couldn't match <tag> match (because the version field had already been changed).

seancorfield05:12:57

So now, :version (and :group-id and :artifact-id) are only passed to t.d.a's pom-sync'ing code when no pom.xml exists.

seancorfield05:12:10

(and in that case, there's no <tag>)

dharrigan05:12:43

YOu know, I did the obvious thing when I first tried it out yesterday, I did sync-pom without reading the documentation (and not having a pom.xml). It threw a NPE to the console. After reading the documentation, I added in the version, groupid etc., and it worked. However, do you think it might be worthwhile to catch that NPE (for dummies like me) and guide the user to add in a groupid, artifactid and version?

seancorfield05:12:51

Probably a good idea. I could even trap it before calling into t.d.a and give a better message altogether.

dharrigan05:12:39

That would be helpful 🙂 Something to ponder.

seancorfield05:12:26

I'll need to clean up the option verification stuff before I can implement that. The code needs a serious refactor. It's at the limit of what I can maintain in the main function right now.

dharrigan05:12:39

you have a lot on your plate! this, honeysql, next.jdbc....

seancorfield05:12:56

The sponsorship really helps... it means I can really justify working on OSS for whole days at a time instead of a few hours here and there.

seancorfield05:12:36

Jay is happy for me to be doing "semi-work" instead of watching TV 🙂

dharrigan05:12:14

🙂 Let me know if I can be of any assistance. Happy to spend a few hours testing things out if you need someone.

seancorfield05:12:27

("work-work" is my day job, "play-work" is unpaid stuff I do on the computer, "semi-work" is the new term for "unpaid stuff I do" that I'm now actually getting paid for)

seancorfield05:12:34

Thanks. You're a very proactive user of several of my projects and that is very valuable on its own because you actually provide feedback (both positive and negative) on how stuff actually works.

dharrigan05:12:45

you're most welcome! 🙂

seancorfield05:12:16

The next "big" piece of work is to break my current logjam on HoneySQL...