datascript

braai engineer 2023-08-07T21:38:15.091169Z

Added DataScript v1.5.0 to my project and get this when I try build via shadow-cljs:

------ WARNING #1 - :undeclared-var --------------------------------------------
 Resource: datascript/db.cljc:106:33
--------------------------------------------------------------------------------
 103 |   (if cljs-env?
 104 |     meta
 105 |     (condp = (:tag meta)
 106 |       'boolean (assoc meta :tag java.lang.Boolean)
---------------------------------------^----------------------------------------
 Use of undeclared Var datascript.db/java
--------------------------------------------------------------------------------
 107 |       'number  (assoc meta :tag clojure.core$long)
 108 |       meta)))
 109 | 
 110 | #?(:clj
--------------------------------------------------------------------------------

------ WARNING #2 - :undeclared-var --------------------------------------------
 Resource: datascript/db.cljc:107:33
--------------------------------------------------------------------------------
 104 |     meta
 105 |     (condp = (:tag meta)
 106 |       'boolean (assoc meta :tag java.lang.Boolean)
 107 |       'number  (assoc meta :tag clojure.core$long)
---------------------------------------^----------------------------------------
 Use of undeclared Var datascript.db/clojure
--------------------------------------------------------------------------------
 108 |       meta)))
 109 | 
 110 | #?(:clj
 111 |    (defmacro declare+ 
--------------------------------------------------------------------------------
I have :compiler-options {:externs ["datascript/externs.js"]} in shadow-cljs.edn.

Sam Ferrell 2023-08-08T00:35:42.497439Z

I also saw that when attempting to upgrade, didn't dig into it though.

Niki 2023-08-08T10:13:08.917129Z

Hm interesting, I wonder why I don’t see it with lein cljsbuild. If shadow compiles differently, we might be in a lot of trouble

Niki 2023-08-08T10:51:53.258709Z

Ok seems like it was indeed shadow doing its shadow things, in particular code analysis. Pushed 1.5.1 that fixes that warning

✅ 2