Fork me on GitHub
#datalevin
<
2022-04-22
>
Eugen14:04:27

@huahaiy: is it ok if I try to implement https://github.com/juji-io/datalevin/issues/108 and provide a PR ? If that works well, I might work on providing the map interface as well.

Huahai16:04:25

We already have Iterable for these, just need to expose it properly, it is also possible to add reduce and map related interfaces to that as well. Since we have multiple modes (library, server, pods) and two bindings (java, graal), adding any public function will have to change many places. It would be difficult to do if one is not familiar with the code base. Of course, if you feel you are up to it, I am not against it. My suggestion is to enhance and expose iterate-kv , and rename the existing one iterate-kv1. The new one will return a type that implements IPersistentMap. Please let me know if you want to take a crack on this. Thanks.

Eugen17:04:38

I would like to try. esp. if you are not in a hurry to make changes there. the pointers you gave are a good start. if you have some strong opinions about how this should be done pls. let me know in advance.

Huahai17:04:54

Sounds good. At the moment, I don’t have opinions other than trying to keep things simple and doing as less work as possible 🙂