cursive 2023-01-26 | Slack Archive

grav10:01:43

A collegeue of mine cannot see the diff for failing tests. The orange dot is simply not shown next to the code. What can the issue be?

grav08:01:36

@U0567Q30W any hints for this issue? 🙂

grega100k15:01:51

There was a pretty long thread on November 2, 2022 that sounds like the same issue

grav18:01:58

Thanks @U2FQAF90R, seems this is the thread: https://clojurians.slack.com/archives/C0744GXCJ/p1667397700150869 Haven't had time to look it through yet with my colleque

cfleming19:01:19

Yes, I was going to add some debug logging, but Empperi then wasn’t working on that project any more. I’ll check whether I got around to adding it, and perhaps @U052XLL3A’s co-worker could test it out.

grav21:01:51

Sure, I'll ask him to try it out 👍

cfleming22:01:28

I’ll check how it works and let you know.

grega100k14:02:27

I am also seeing this issue so could also help test this.

Anders Corlin22:09:58

I see the markers in versions 1.12.1 - 1.12.3, but no longer in 1.12.4 and above. My main environment is IntelliJ Ultimate 2023.1.5 with Cursive 1.13.0, but also reproduced in IntelliJ 2021.3.3 with Cursive 1.12.4 and above. I'm on Windows. For my colleague on Linux it works with the latest version. I created the below issue for it, but haven't heard anything back for a couple of months. https://github.com/cursive-ide/cursive/issues/2762

cfleming22:09:32

@U05Q6BCP6DV Thanks, I’ll take a look at the changes in that release and see what I can see that might be related.

🙌 1

Anders Corlin08:10:46

Thanks Colin! Downloaded EAP-8 and the test markers are back! I'm so grateful, this makes my life so much easier not having to switch back to IntelliJ 2021 every time I need to run my tests!! 🙏 🙌 🙏 🙌 🙏 🙌 🙏 🙌 🙏 🙌

cfleming08:10:55

No problem Anders, I’m just sorry this took so long to fix. I had to set up a Windows VM to test it which was surprisingly painful. But I’m really glad it works for you, that’s great news!

Anders Corlin08:10:19

Yeah, supporting multiple platforms with a small team is grueling, there's so much knowledge you need to gather and it's constantly changing!

cfleming08:10:14

No doubt, and Clojure on Windows just seems to have so many options - it’s a bit like CLJS in that respect. Anyway, I have the testing setup done now, so hopefully repro’ing Windows issues will be easier now.

🪟 1

roklenarcic17:01:30

sometimes when using Add import autofix in my code the namespace declaration structure is updated by Cursive:

(ns user
  (:require [ :as io]
            [clojure.string :as string]
            [clojure.pprint :refer (pprint)]
            [clojure.repl :as repl]
            [clojure.test :as test]

(ns user
  (:require
    [clj-http.client :as http]
    [ :as io]
    [clojure.string :as string]

I’d rather it didn’t do that. How? Also I see there’s support for single space ident, but does that correctly handle if macros and such… it seems not…

➕ 2

cfleming21:01:14

That’s https://github.com/cursive-ide/cursive/issues/2763, which is fixed for the next build.

cfleming21:01:40

I think the single space indent should handle if forms.

roklenarcic08:01:30

in my testing it works like this:

(if a
  b
  c)

but if you break before first argument it does single space for the condition and 2 for clauses:

(if
 a
  b
  c)

also something like or does single space where I would expect 2:

(or
 a
 b)

This is mostly an issue where other members of the team use the typical single space solution where things have single space ident and some macros have 2 space ident, and I keep breaking this formatting. Also for import, I’d prefer that the existing formatting wasn’t changed when imports are added.

cfleming08:01:15

I’ll look at the if problem, thanks.

cfleming08:01:24

What are the problems you’re seeing with imports?

roklenarcic08:01:27

in our files we have a mix of different require statement formats:

(:require [....

also

(:require
 [.....

also

(:require
  [.....

I just don’t like it when it reformats the thing (and introduces many lines of git changes)

2023-01-26

Channels