Good man Colin, this is super later for you there

Yep, I’ll be off to bed shortly 🙂

let me give it a quick try

(you don't have to wait for it lol)

Haha, I’ll be here for a little bit anyway

Was it something stupid that broke it?

It’s an extremely weird one. I can’t figure out how it ever worked at all. And I’ve trawled through the history of all the related files, and nothing changed in them recently. So I’m still not sure that I’ve fixed it, although the thing I fixed was definitely broken.

Wow. Was it resolution-related or settings-management related?

I installed this from disk, loaded up a project that showed this problem before and had my symbols resolved properly, so the first try succeeded

It was a confusing combination of the two. When the settings for the resolution customisations are loaded, there’s a map which wasn’t being initialised, which goes from the short name (e.g. defmutation) to a set of vars which have that short name (e.g Pathom’s defmutation, Fulcro’s defmutation, and any others you might have configured). That short name cache was correctly initialised for all the built in extensions, but not for the customisations, which is why they didn’t work. However, that code has been like that forever, so I don’t know how the customisations (at least the ones relating to indexing, e.g. resolve as def/defn) ever worked at all.

Re-customising did set that cache correctly, but that would have been lost on every restart. So this should have lost everyone’s customisations on every restart, which clearly wasn’t happening.

Great news!

So, there’s something I still don’t understand, which is frustrating.

wow that does sound weird

I'll keep trying and let you know

if I see any more issues

There are definitely some IntelliJ indexing bugs in there too, probably in 2022.1 since I haven’t seen them previously. The IDE would occasionally just stop resolving anything at all, and e.g. not find any namespaces to navigate to. That’s definitely a platform issue, but I’ll just have to hope they can fix that, I don’t have enough for a coherent bug report yet.

Great, thanks.

upgrading now

@U0567Q30W Can confirm it's no longer throwing errors and all ops (navigate, quick doc, etc.) are looking fine.

That is definitely 🎉

Just wanna say, really appreciate you staying up late trying to get this fixed 🙂

No problem! I am very glad to hopefully have it fixed.

Yes, thank you! I'll pull this in and check it out but I certainly appreciate the efforts here as well

No problem, I’m sorry this has been painful for so long.